Skip to content

Commit dd76e21

Browse files
author
Colin Reisterer
committed
Rename to PNChartSwift
Hyphen in name was causing issues importing framework. (While you should be able to use "_" in place of "-", was getting no module found when trying to import framework in tests. Confirmed this issue with a new framework as well with Xcode New Project wizard.)
1 parent e3c84a5 commit dd76e21

File tree

10 files changed

+40
-69
lines changed

10 files changed

+40
-69
lines changed

‎PNChart-Swift/PNChart-Swift.h renamed to ‎PNChart-Swift/PNChartSwift.h

File renamed without changes.

‎PNChart-SwiftTests/FrameworkTests.swift

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎PNChart-SwiftTests/PNChart_SwiftTests.swift renamed to ‎PNChart-SwiftTests/PNChartSwiftTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import XCTest
1010
import Foundation
11-
import PNChart_Swift
11+
import PNChartSwift
1212

1313
class PNChart_SwiftTests: XCTestCase {
1414

‎PNChart-Swift.xcodeproj/project.pbxproj renamed to ‎PNChartSwift.xcodeproj/project.pbxproj

Lines changed: 38 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,20 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10-
0AADA0D7193E5A320063B15C /* PNChart_SwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0AADA0D6193E5A320063B15C /* PNChart_SwiftTests.swift */; };
10+
0AADA0D7193E5A320063B15C /* PNChartSwiftTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0AADA0D6193E5A320063B15C /* PNChartSwiftTests.swift */; };
1111
12E6A9F11A0778DE00B087DB /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 0AADA0CA193E5A320063B15C /* Images.xcassets */; };
12-
9C35F7B61A9515F900B293F0 /* PNChart-Swift.h in Headers */ = {isa = PBXBuildFile; fileRef = 9C35F7B51A9515F900B293F0 /* PNChart-Swift.h */; settings = {ATTRIBUTES = (Public, ); }; };
13-
9C35F7B81A951C5400B293F0 /* FrameworkTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9C35F7B71A951C5400B293F0 /* FrameworkTests.swift */; };
14-
9C35F7C31A9523DC00B293F0 /* PNChart-Swift.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 12E6A9CB1A0778B900B087DB /* PNChart-Swift.framework */; };
12+
9C35F7B61A9515F900B293F0 /* PNChartSwift.h in Headers */ = {isa = PBXBuildFile; fileRef = 9C35F7B51A9515F900B293F0 /* PNChartSwift.h */; settings = {ATTRIBUTES = (Public, ); }; };
13+
9C35F7C31A9523DC00B293F0 /* PNChartSwift.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 12E6A9CB1A0778B900B087DB /* PNChartSwift.framework */; };
1514
/* End PBXBuildFile section */
1615

1716
/* Begin PBXFileReference section */
1817
0A840E3519DBDE2600D4C582 /* view.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = view.swift; sourceTree = "<group>"; };
1918
0AADA0C0193E5A320063B15C /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
2019
0AADA0CA193E5A320063B15C /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Images.xcassets; sourceTree = "<group>"; };
21-
0AADA0D0193E5A320063B15C /* PNChart-SwiftTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "PNChart-SwiftTests.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
20+
0AADA0D0193E5A320063B15C /* PNChartSwiftTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = PNChartSwiftTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
2221
0AADA0D5193E5A320063B15C /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
23-
0AADA0D6193E5A320063B15C /* PNChart_SwiftTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PNChart_SwiftTests.swift; sourceTree = "<group>"; };
24-
12E6A9CB1A0778B900B087DB /* PNChart-Swift.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = "PNChart-Swift.framework"; sourceTree = BUILT_PRODUCTS_DIR; };
22+
0AADA0D6193E5A320063B15C /* PNChartSwiftTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PNChartSwiftTests.swift; sourceTree = "<group>"; };
23+
12E6A9CB1A0778B900B087DB /* PNChartSwift.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = PNChartSwift.framework; sourceTree = BUILT_PRODUCTS_DIR; };
2524
9C35F77E1A95150300B293F0 /* PNBar.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNBar.swift; sourceTree = "<group>"; };
2625
9C35F77F1A95150300B293F0 /* PNBarChart.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNBarChart.swift; sourceTree = "<group>"; };
2726
9C35F7821A95150C00B293F0 /* PNChartConfig.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNChartConfig.swift; sourceTree = "<group>"; };
@@ -30,16 +29,15 @@
3029
9C35F7881A95151E00B293F0 /* PNLineChart.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNLineChart.swift; sourceTree = "<group>"; };
3130
9C35F7891A95151E00B293F0 /* PNLineChartData.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNLineChartData.swift; sourceTree = "<group>"; };
3231
9C35F78D1A95152700B293F0 /* PNValue.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PNValue.swift; sourceTree = "<group>"; };
33-
9C35F7B51A9515F900B293F0 /* PNChart-Swift.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "PNChart-Swift.h"; sourceTree = "<group>"; };
34-
9C35F7B71A951C5400B293F0 /* FrameworkTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FrameworkTests.swift; sourceTree = "<group>"; };
32+
9C35F7B51A9515F900B293F0 /* PNChartSwift.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PNChartSwift.h; sourceTree = "<group>"; };
3533
/* End PBXFileReference section */
3634

3735
/* Begin PBXFrameworksBuildPhase section */
3836
0AADA0CD193E5A320063B15C /* Frameworks */ = {
3937
isa = PBXFrameworksBuildPhase;
4038
buildActionMask = 2147483647;
4139
files = (
42-
9C35F7C31A9523DC00B293F0 /* PNChart-Swift.framework in Frameworks */,
40+
9C35F7C31A9523DC00B293F0 /* PNChartSwift.framework in Frameworks */,
4341
);
4442
runOnlyForDeploymentPostprocessing = 0;
4543
};
@@ -56,25 +54,25 @@
5654
0AADA0B3193E5A320063B15C = {
5755
isa = PBXGroup;
5856
children = (
59-
0AADA0BE193E5A320063B15C /* PNChart-Swift */,
60-
0AADA0D3193E5A320063B15C /* PNChart-SwiftTests */,
57+
0AADA0BE193E5A320063B15C /* PNChartSwift */,
58+
0AADA0D3193E5A320063B15C /* PNChartSwiftTests */,
6159
0AADA0BD193E5A320063B15C /* Products */,
6260
);
6361
sourceTree = "<group>";
6462
};
6563
0AADA0BD193E5A320063B15C /* Products */ = {
6664
isa = PBXGroup;
6765
children = (
68-
0AADA0D0193E5A320063B15C /* PNChart-SwiftTests.xctest */,
69-
12E6A9CB1A0778B900B087DB /* PNChart-Swift.framework */,
66+
0AADA0D0193E5A320063B15C /* PNChartSwiftTests.xctest */,
67+
12E6A9CB1A0778B900B087DB /* PNChartSwift.framework */,
7068
);
7169
name = Products;
7270
sourceTree = "<group>";
7371
};
74-
0AADA0BE193E5A320063B15C /* PNChart-Swift */ = {
72+
0AADA0BE193E5A320063B15C /* PNChartSwift */ = {
7573
isa = PBXGroup;
7674
children = (
77-
9C35F7B51A9515F900B293F0 /* PNChart-Swift.h */,
75+
9C35F7B51A9515F900B293F0 /* PNChartSwift.h */,
7876
9C35F77D1A95150300B293F0 /* PNBarChart */,
7977
9C35F7861A95151E00B293F0 /* PNLineChart */,
8078
9C35F78D1A95152700B293F0 /* PNValue.swift */,
@@ -84,6 +82,7 @@
8482
0AADA0CA193E5A320063B15C /* Images.xcassets */,
8583
0AADA0BF193E5A320063B15C /* Supporting Files */,
8684
);
85+
name = PNChartSwift;
8786
path = "PNChart-Swift";
8887
sourceTree = "<group>";
8988
};
@@ -95,13 +94,13 @@
9594
name = "Supporting Files";
9695
sourceTree = "<group>";
9796
};
98-
0AADA0D3193E5A320063B15C /* PNChart-SwiftTests */ = {
97+
0AADA0D3193E5A320063B15C /* PNChartSwiftTests */ = {
9998
isa = PBXGroup;
10099
children = (
101-
0AADA0D6193E5A320063B15C /* PNChart_SwiftTests.swift */,
102-
9C35F7B71A951C5400B293F0 /* FrameworkTests.swift */,
100+
0AADA0D6193E5A320063B15C /* PNChartSwiftTests.swift */,
103101
0AADA0D4193E5A320063B15C /* Supporting Files */,
104102
);
103+
name = PNChartSwiftTests;
105104
path = "PNChart-SwiftTests";
106105
sourceTree = "<group>";
107106
};
@@ -139,16 +138,16 @@
139138
isa = PBXHeadersBuildPhase;
140139
buildActionMask = 2147483647;
141140
files = (
142-
9C35F7B61A9515F900B293F0 /* PNChart-Swift.h in Headers */,
141+
9C35F7B61A9515F900B293F0 /* PNChartSwift.h in Headers */,
143142
);
144143
runOnlyForDeploymentPostprocessing = 0;
145144
};
146145
/* End PBXHeadersBuildPhase section */
147146

148147
/* Begin PBXNativeTarget section */
149-
0AADA0CF193E5A320063B15C /* PNChart-SwiftTests */ = {
148+
0AADA0CF193E5A320063B15C /* PNChartSwiftTests */ = {
150149
isa = PBXNativeTarget;
151-
buildConfigurationList = 0AADA0DD193E5A320063B15C /* Build configuration list for PBXNativeTarget "PNChart-SwiftTests" */;
150+
buildConfigurationList = 0AADA0DD193E5A320063B15C /* Build configuration list for PBXNativeTarget "PNChartSwiftTests" */;
152151
buildPhases = (
153152
0AADA0CC193E5A320063B15C /* Sources */,
154153
0AADA0CD193E5A320063B15C /* Frameworks */,
@@ -158,14 +157,14 @@
158157
);
159158
dependencies = (
160159
);
161-
name = "PNChart-SwiftTests";
160+
name = PNChartSwiftTests;
162161
productName = "PNChart-SwiftTests";
163-
productReference = 0AADA0D0193E5A320063B15C /* PNChart-SwiftTests.xctest */;
162+
productReference = 0AADA0D0193E5A320063B15C /* PNChartSwiftTests.xctest */;
164163
productType = "com.apple.product-type.bundle.unit-test";
165164
};
166-
12E6A9CA1A0778B900B087DB /* PNChart-Swift */ = {
165+
12E6A9CA1A0778B900B087DB /* PNChartSwift */ = {
167166
isa = PBXNativeTarget;
168-
buildConfigurationList = 12E6A9E21A0778B900B087DB /* Build configuration list for PBXNativeTarget "PNChart-Swift" */;
167+
buildConfigurationList = 12E6A9E21A0778B900B087DB /* Build configuration list for PBXNativeTarget "PNChartSwift" */;
169168
buildPhases = (
170169
12E6A9C61A0778B900B087DB /* Sources */,
171170
12E6A9C71A0778B900B087DB /* Frameworks */,
@@ -176,9 +175,9 @@
176175
);
177176
dependencies = (
178177
);
179-
name = "PNChart-Swift";
178+
name = PNChartSwift;
180179
productName = PNChart;
181-
productReference = 12E6A9CB1A0778B900B087DB /* PNChart-Swift.framework */;
180+
productReference = 12E6A9CB1A0778B900B087DB /* PNChartSwift.framework */;
182181
productType = "com.apple.product-type.framework";
183182
};
184183
/* End PBXNativeTarget section */
@@ -198,7 +197,7 @@
198197
};
199198
};
200199
};
201-
buildConfigurationList = 0AADA0B7193E5A320063B15C /* Build configuration list for PBXProject "PNChart-Swift" */;
200+
buildConfigurationList = 0AADA0B7193E5A320063B15C /* Build configuration list for PBXProject "PNChartSwift" */;
202201
compatibilityVersion = "Xcode 3.2";
203202
developmentRegion = English;
204203
hasScannedForEncodings = 0;
@@ -210,8 +209,8 @@
210209
projectDirPath = "";
211210
projectRoot = "";
212211
targets = (
213-
0AADA0CF193E5A320063B15C /* PNChart-SwiftTests */,
214-
12E6A9CA1A0778B900B087DB /* PNChart-Swift */,
212+
0AADA0CF193E5A320063B15C /* PNChartSwiftTests */,
213+
12E6A9CA1A0778B900B087DB /* PNChartSwift */,
215214
);
216215
};
217216
/* End PBXProject section */
@@ -239,8 +238,7 @@
239238
isa = PBXSourcesBuildPhase;
240239
buildActionMask = 2147483647;
241240
files = (
242-
9C35F7B81A951C5400B293F0 /* FrameworkTests.swift in Sources */,
243-
0AADA0D7193E5A320063B15C /* PNChart_SwiftTests.swift in Sources */,
241+
0AADA0D7193E5A320063B15C /* PNChartSwiftTests.swift in Sources */,
244242
);
245243
runOnlyForDeploymentPostprocessing = 0;
246244
};
@@ -345,7 +343,7 @@
345343
INFOPLIST_FILE = "PNChart-SwiftTests/Info.plist";
346344
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
347345
METAL_ENABLE_DEBUG_INFO = YES;
348-
PRODUCT_NAME = "$(TARGET_NAME)";
346+
PRODUCT_NAME = PNChartSwiftTests;
349347
};
350348
name = Debug;
351349
};
@@ -359,7 +357,7 @@
359357
INFOPLIST_FILE = "PNChart-SwiftTests/Info.plist";
360358
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
361359
METAL_ENABLE_DEBUG_INFO = NO;
362-
PRODUCT_NAME = "$(TARGET_NAME)";
360+
PRODUCT_NAME = PNChartSwiftTests;
363361
};
364362
name = Release;
365363
};
@@ -381,7 +379,7 @@
381379
IPHONEOS_DEPLOYMENT_TARGET = 8.1;
382380
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
383381
MTL_ENABLE_DEBUG_INFO = YES;
384-
PRODUCT_NAME = "$(TARGET_NAME)";
382+
PRODUCT_NAME = PNChartSwift;
385383
SKIP_INSTALL = YES;
386384
TARGETED_DEVICE_FAMILY = "1,2";
387385
VERSIONING_SYSTEM = "apple-generic";
@@ -403,7 +401,7 @@
403401
IPHONEOS_DEPLOYMENT_TARGET = 8.1;
404402
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
405403
MTL_ENABLE_DEBUG_INFO = NO;
406-
PRODUCT_NAME = "$(TARGET_NAME)";
404+
PRODUCT_NAME = PNChartSwift;
407405
SKIP_INSTALL = YES;
408406
TARGETED_DEVICE_FAMILY = "1,2";
409407
VERSIONING_SYSTEM = "apple-generic";
@@ -414,7 +412,7 @@
414412
/* End XCBuildConfiguration section */
415413

416414
/* Begin XCConfigurationList section */
417-
0AADA0B7193E5A320063B15C /* Build configuration list for PBXProject "PNChart-Swift" */ = {
415+
0AADA0B7193E5A320063B15C /* Build configuration list for PBXProject "PNChartSwift" */ = {
418416
isa = XCConfigurationList;
419417
buildConfigurations = (
420418
0AADA0D8193E5A320063B15C /* Debug */,
@@ -423,7 +421,7 @@
423421
defaultConfigurationIsVisible = 0;
424422
defaultConfigurationName = Release;
425423
};
426-
0AADA0DD193E5A320063B15C /* Build configuration list for PBXNativeTarget "PNChart-SwiftTests" */ = {
424+
0AADA0DD193E5A320063B15C /* Build configuration list for PBXNativeTarget "PNChartSwiftTests" */ = {
427425
isa = XCConfigurationList;
428426
buildConfigurations = (
429427
0AADA0DE193E5A320063B15C /* Debug */,
@@ -432,7 +430,7 @@
432430
defaultConfigurationIsVisible = 0;
433431
defaultConfigurationName = Release;
434432
};
435-
12E6A9E21A0778B900B087DB /* Build configuration list for PBXNativeTarget "PNChart-Swift" */ = {
433+
12E6A9E21A0778B900B087DB /* Build configuration list for PBXNativeTarget "PNChartSwift" */ = {
436434
isa = XCConfigurationList;
437435
buildConfigurations = (
438436
12E6A9DE1A0778B900B087DB /* Debug */,

‎PNChart-Swift.xcodeproj/project.xcworkspace/contents.xcworkspacedata renamed to ‎PNChartSwift.xcodeproj/project.xcworkspace/contents.xcworkspacedata

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎PNChart-Swift.xcodeproj/project.xcworkspace/xcshareddata/PNChart-Swift.xccheckout renamed to ‎PNChartSwift.xcodeproj/project.xcworkspace/xcshareddata/PNChart-Swift.xccheckout

File renamed without changes.

‎PNChart-Swift.xcodeproj/project.xcworkspace/xcuserdata/kevin.xcuserdatad/UserInterfaceState.xcuserstate renamed to ‎PNChartSwift.xcodeproj/project.xcworkspace/xcuserdata/kevin.xcuserdatad/UserInterfaceState.xcuserstate

File renamed without changes.

‎PNChart-Swift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist renamed to ‎PNChartSwift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist

File renamed without changes.

‎PNChart-Swift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcschemes/PNChart-Swift.xcscheme renamed to ‎PNChartSwift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcschemes/PNChart-Swift.xcscheme

File renamed without changes.

‎PNChart-Swift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcschemes/xcschememanagement.plist renamed to ‎PNChartSwift.xcodeproj/xcuserdata/kevin.xcuserdatad/xcschemes/xcschememanagement.plist

File renamed without changes.

0 commit comments

Comments
 (0)