From a489ca7cd18c8e99067587ce712287736821b83f Mon Sep 17 00:00:00 2001 From: Laszlo Kishalmi Date: Fri, 2 Dec 2022 00:06:04 -0800 Subject: [PATCH] NewRelic scaler crashes on logging (#3946) Signed-off-by: Laszlo Kishalmi Signed-off-by: Laszlo Kishalmi --- CHANGELOG.md | 1 + pkg/scalers/newrelic_scaler.go | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 993702132d4..2c11ac13090 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -76,6 +76,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio - **General:** Provide patch for CVE-2022-3172 vulnerability ([#3690](https://github.com/kedacore/keda/issues/3690)) - **General:** Respect optional parameter inside envs for ScaledJobs ([#3568](https://github.com/kedacore/keda/issues/3568)) - **Azure Blob Scaler** Store forgotten logger ([#3811](https://github.com/kedacore/keda/issues/3811)) +- **New Relic Scaler** Store forgotten logger ([#3945](https://github.com/kedacore/keda/issues/3945)) - **Prometheus Scaler:** Treat Inf the same as Null result ([#3644](https://github.com/kedacore/keda/issues/3644)) - **NATS Jetstream:** Correctly count messages that should be redelivered (waiting for ack) towards keda value ([#3787](https://github.com/kedacore/keda/issues/3787)) diff --git a/pkg/scalers/newrelic_scaler.go b/pkg/scalers/newrelic_scaler.go index cf2fd78bebb..7e5fa565625 100644 --- a/pkg/scalers/newrelic_scaler.go +++ b/pkg/scalers/newrelic_scaler.go @@ -71,7 +71,8 @@ func NewNewRelicScaler(config *ScalerConfig) (Scaler, error) { return &newrelicScaler{ metricType: metricType, metadata: meta, - nrClient: nrClient}, nil + nrClient: nrClient, + logger: logger}, nil } func parseNewRelicMetadata(config *ScalerConfig, logger logr.Logger) (*newrelicMetadata, error) {