Better error handling + support Idempotency-Key

Author: kevinresol

playground.hxml

@@ -1,5 +1,7 @@
 -cp tests
 -main Playground
 -js bin/playground.js
+-dce full
+
 -lib stripe
 -lib hxnodejs

src/stripe/Stripe.hx

@@ -13,24 +13,32 @@ private typedef Impl = Remote<stripe.api.Stripe>;
 
 @:forward
 abstract Stripe(Impl) {
-	public inline function new(apiKey, client) {
-		this = new Impl(new AuthedClient(apiKey, client), new RemoteEndpoint(new Host('api.stripe.com', 443)));
+	public inline function new(apiKey, client:Client, ?idempotencyKey) {
+		client = new AuthedClient(apiKey, client);
+		if(idempotencyKey != null) client = new IdempotentClient(idempotencyKey, client);
+		this = new Impl(client, new RemoteEndpoint(new Host('api.stripe.com', 443)));
 	}
 }
 
-class AuthedClient implements ClientObject {
-	var apiKey:String;
+class AuthedClient extends AppendHeaderClient {
+	public function new(apiKey, client)
+		super(AUTHORIZATION, 'Bearer $apiKey', client);
+}
+
+class IdempotentClient extends AppendHeaderClient {
+	public function new(key, client)
+		super('Idempotency-Key', key, client);
+}
+
+class AppendHeaderClient implements ClientObject {
+	var field:HeaderField;
 	var client:Client;
-	public function new(apiKey, client) {
-		this.apiKey = apiKey;
+	
+	public function new(name, value, client) {
+		this.field = new HeaderField(name, value);
 		this.client = client;
 	}
 
-	public function request(req:OutgoingRequest):Promise<IncomingResponse> {
-		trace(haxe.Json.stringify(apiKey));
-		return client.request(new OutgoingRequest(
-			req.header.concat([new HeaderField(AUTHORIZATION, 'Bearer $apiKey')]),
-			req.body
-		));
-	}
+	public function request(req:OutgoingRequest):Promise<IncomingResponse>
+		return client.request(new OutgoingRequest(req.header.concat([field]), req.body));
 }

src/stripe/api/Charges.hx

@@ -25,10 +25,5 @@ interface Charges {
 		?customer:String,
 		?source:String, // or a hash containing card info
 		?statement_descriptor:String,
-	}):ChargeResponse;
-}
-
-typedef ChargeResponse = {
-	>Response,
-	>Charge,
+	}):Charge;
 }

src/stripe/api/Customers.hx

@@ -15,10 +15,5 @@ interface Customers {
 		// ?metadata:Metadata, // need support in tink_querystring
 		?shipping:Shipping,
 		?source:String, // or Card
-	}):CustomerResponse;
-}
-
-typedef CustomerResponse = {
-	>Response,
-	>Customer,
+	}):Customer;
 }

src/stripe/api/Stripe.hx

@@ -1,9 +1,12 @@
 package stripe.api;
 
 interface Stripe {
+	
 	@:sub('/v1/customers')
 	var customers:Customers;
+	
 	@:sub('/v1/charges')
 	var charges:Charges;
-}
-
+	
+	
+}

src/stripe/types/Error.hx

@@ -1,14 +1,25 @@
 package stripe.types;
 
 import tink.json.Value;
+using tink.CoreApi;
 
-typedef Error = {
-	type:ErrorType,
-	?charge:String,
-	?message:String,
-	?code:String,
-	?decline_code:String,
-	?param:Value,
+abstract Error(ErrorData) {
+	inline function new(v)
+		this = v;
+		
+	public static function parse(v:String)
+		return tink.Json.parse((v:ErrorData)).map(Error.new);
+}
+
+typedef ErrorData = {
+	error: {
+		type:ErrorType,
+		?charge:String,
+		?message:String,
+		?code:String,
+		?decline_code:String,
+		?param:Value,
+	}
 }
 
 @:enum

tests/Playground.hx

@@ -2,6 +2,7 @@ package;
 
 import tink.http.clients.*;
 import stripe.Stripe;
+import stripe.types.*;
 
 class Playground {
 	static function main() {
@@ -21,7 +22,7 @@ class Playground {
 					trace(data, '');
 				case Failure(err): 
 					trace(err);
-					trace(haxe.Json.parse(err.data));
+					trace(Error.parse(err.data));
 			});
 	}
 }