Assign normalized decimal value representations to non-decimal number tokens (microsoft#583)

Author: Andarist

internal/scanner/scanner.go

@@ -1863,14 +1863,6 @@ func (s *Scanner) scanBigIntSuffix() ast.Kind {
 		// !!! Convert all bigint tokens to their normalized decimal representation
 		return ast.KindBigIntLiteral
 	}
-	// !!! Once core.StringToNumber supports parsing of non-decimal values we should also convert non-decimal
-	// tokens to their normalized decimal representation
-	if len(s.tokenValue) >= 2 {
-		firstTwo := s.tokenValue[:2]
-		if firstTwo == "0x" || firstTwo == "0o" || firstTwo == "0b" {
-			return ast.KindNumericLiteral
-		}
-	}
 	s.tokenValue = jsnum.FromString(s.tokenValue).String()
 	return ast.KindNumericLiteral
 }

testdata/baselines/reference/submodule/compiler/duplicateIdentifierDifferentSpelling.errors.txt

@@ -0,0 +1,19 @@
+duplicateIdentifierDifferentSpelling.ts(2,3): error TS2300: Duplicate identifier '0b11'.
+duplicateIdentifierDifferentSpelling.ts(3,3): error TS2300: Duplicate identifier '0b11'.
+duplicateIdentifierDifferentSpelling.ts(6,21): error TS1117: An object literal cannot have multiple properties with the same name.
+
+
+==== duplicateIdentifierDifferentSpelling.ts (3 errors) ====
+    class A {
+      0b11 = '';
+      ~~~~
+!!! error TS2300: Duplicate identifier '0b11'.
+      3 = '';
+      ~
+!!! error TS2300: Duplicate identifier '0b11'.
+    }
+    
+    var X = { 0b11: '', 3: '' };
+                        ~
+!!! error TS1117: An object literal cannot have multiple properties with the same name.
+    

testdata/baselines/reference/submodule/compiler/duplicateIdentifierDifferentSpelling.errors.txt.diff

@@ -1,21 +1,22 @@
 --- old.duplicateIdentifierDifferentSpelling.errors.txt
 +++ new.duplicateIdentifierDifferentSpelling.errors.txt
-@@= skipped -0, +-1 lines =@@
+@@= skipped -0, +0 lines =@@
 -duplicateIdentifierDifferentSpelling.ts(3,3): error TS2300: Duplicate identifier '3'.
--duplicateIdentifierDifferentSpelling.ts(6,21): error TS1117: An object literal cannot have multiple properties with the same name.
--
--
++duplicateIdentifierDifferentSpelling.ts(2,3): error TS2300: Duplicate identifier '0b11'.
++duplicateIdentifierDifferentSpelling.ts(3,3): error TS2300: Duplicate identifier '0b11'.
+ duplicateIdentifierDifferentSpelling.ts(6,21): error TS1117: An object literal cannot have multiple properties with the same name.
+ 
+ 
 -==== duplicateIdentifierDifferentSpelling.ts (2 errors) ====
--    class A {
--      0b11 = '';
--      3 = '';
--      ~
++==== duplicateIdentifierDifferentSpelling.ts (3 errors) ====
+     class A {
+       0b11 = '';
++      ~~~~
++!!! error TS2300: Duplicate identifier '0b11'.
+       3 = '';
+       ~
 -!!! error TS2300: Duplicate identifier '3'.
--    }
--    
--    var X = { 0b11: '', 3: '' };
--                        ~
--!!! error TS1117: An object literal cannot have multiple properties with the same name.
--    
-@@= skipped --1, +1 lines =@@
-+<no content>
++!!! error TS2300: Duplicate identifier '0b11'.
+     }
+     
+     var X = { 0b11: '', 3: '' };

testdata/baselines/reference/submodule/compiler/duplicateIdentifierDifferentSpelling.symbols

@@ -5,14 +5,14 @@ class A {
 >A : Symbol(A, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 0))
 
   0b11 = '';
->0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9))
+>0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
 
   3 = '';
->3 : Symbol(3, Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
+>3 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
 }
 
 var X = { 0b11: '', 3: '' };
 >X : Symbol(X, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 3))
->0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9))
->3 : Symbol(3, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
+>0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
+>3 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
 

testdata/baselines/reference/submodule/compiler/duplicateIdentifierDifferentSpelling.symbols.diff

@@ -5,17 +5,11 @@
 
    0b11 = '';
 ->0b11 : Symbol(A[0b11], Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
-+>0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9))
++>0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
 
    3 = '';
 ->3 : Symbol(A[0b11], Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
-+>3 : Symbol(3, Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
++>3 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 0, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 1, 12))
  }
 
  var X = { 0b11: '', 3: '' };
- >X : Symbol(X, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 3))
-->0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
-->3 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9), Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
-+>0b11 : Symbol(0b11, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 9))
-+>3 : Symbol(3, Decl(duplicateIdentifierDifferentSpelling.ts, 5, 19))
- 

testdata/baselines/reference/submodule/compiler/enumIdentifierLiterals.errors.txt

@@ -1,9 +1,10 @@
 enumIdentifierLiterals.ts(2,5): error TS2452: An enum member cannot have a numeric name.
 enumIdentifierLiterals.ts(3,5): error TS2452: An enum member cannot have a numeric name.
 enumIdentifierLiterals.ts(4,5): error TS2452: An enum member cannot have a numeric name.
+enumIdentifierLiterals.ts(6,5): error TS2452: An enum member cannot have a numeric name.
 
 
-==== enumIdentifierLiterals.ts (3 errors) ====
+==== enumIdentifierLiterals.ts (4 errors) ====
     enum Nums {
         1.0,
         ~~~
@@ -16,4 +17,6 @@ enumIdentifierLiterals.ts(4,5): error TS2452: An enum member cannot have a numer
 !!! error TS2452: An enum member cannot have a numeric name.
         "13e-1",
         0xF00D
+        ~~~~~~
+!!! error TS2452: An enum member cannot have a numeric name.
     }