Adopt clippy suggestions

Author: kevinbader

src/find_projects.rs

@@ -13,7 +13,7 @@ pub fn projects_below<'a>(
 ) -> impl Iterator<Item = Project> + 'a {
     let path = path.canonicalize().expect("canonicalized path");
 
-    WalkBuilder::new(&path)
+    WalkBuilder::new(path)
         .standard_filters(true)
         // skip ignored directories even outside Git repositories
         .require_git(false)
@@ -87,7 +87,7 @@ mod test {
         let _ = OpenOptions::new()
             .create_new(true)
             .write(true)
-            .open(&path.as_ref().join("projectfile"))
+            .open(path.as_ref().join("projectfile"))
             .expect("creating the fake project");
     }
 
@@ -169,7 +169,7 @@ mod test {
         hidden_dir.create_dir_all().unwrap();
         let hidden_dir_path = hidden_dir.path().canonicalize().unwrap();
 
-        fake_project_at(&hidden_dir_path);
+        fake_project_at(hidden_dir_path);
         let projects: Vec<Project> =
             projects_below(&root_path, &project_filter(), &build_tool_manager()).collect();
 
@@ -189,7 +189,7 @@ mod test {
         ignored_dir.create_dir_all().unwrap();
         let ignored_dir_path = ignored_dir.path().canonicalize().unwrap();
 
-        fake_project_at(&ignored_dir_path);
+        fake_project_at(ignored_dir_path);
         let projects: Vec<Project> =
             projects_below(&root_path, &project_filter(), &build_tool_manager()).collect();
 

src/lib.rs

@@ -236,7 +236,7 @@ pub fn clean(cli: Cli, build_tool_manager: BuildToolManager) -> anyhow::Result<(
 
 fn theme() -> Box<dyn Theme> {
     if colors_enabled() {
-        Box::new(ColorfulTheme::default())
+        Box::<ColorfulTheme>::default()
     } else {
         Box::new(SimpleTheme {})
     }

src/project/archive.rs

@@ -57,7 +57,7 @@ impl Project {
         tempdir.close()?;
 
         // Remove the project's contents
-        fs::remove_dir_all(&renamed_project_path)?;
+        fs::remove_dir_all(renamed_project_path)?;
 
         Ok(final_tar_xz_path)
     }

src/project/vcs.rs

@@ -93,7 +93,7 @@ mod test {
         level1_ignored_dir.create_dir_all()?;
 
         root.child(".gitignore").write_str("/foo/ignored_dir")?;
-        let _ = Repository::init(&root.path())?;
+        let _ = Repository::init(root.path())?;
 
         // We operate in the "foo" subdirectory
         let vcs = VersionControlSystem::try_from(&path_of(&level0_foo))

tests/tests/archive.rs

@@ -55,7 +55,7 @@ fn archive_cleans_then_packs_includes_hidden_files_then_removes_project_files()
     // Let's use a new temporary directory for this..
     let extract_root = TempDir::new()?;
 
-    let tar_xz = File::open(&project_dir.join(fname)).unwrap();
+    let tar_xz = File::open(project_dir.join(fname)).unwrap();
     let tar = XzDecoder::new(tar_xz);
     let mut archive = tar::Archive::new(tar);
     archive.unpack(extract_root.path()).unwrap();
@@ -119,7 +119,7 @@ fn any_projects_within_a_to_be_archived_project_are_only_cleaned_but_not_archive
 
     // Extract the result:
     let extract_root = TempDir::new()?;
-    let tar_xz = File::open(&project_dir.join("cargo_test_project.tar.xz")).unwrap();
+    let tar_xz = File::open(project_dir.join("cargo_test_project.tar.xz")).unwrap();
     let tar = XzDecoder::new(tar_xz);
     let mut archive = tar::Archive::new(tar);
     archive.unpack(extract_root.path()).unwrap();

tests/tests/list.rs

@@ -53,7 +53,7 @@ fn directories_ignored_by_git_are_not_considered() -> Result<()> {
 
     // Only the project in `normal_dir` is returned:
     let project: ProjectDto = serde_json::from_str(output.trim()).unwrap();
-    assert_eq!(project.path, canonicalized_str(&root.join("normal_dir")));
+    assert_eq!(project.path, canonicalized_str(root.join("normal_dir")));
 
     Ok(())
 }
@@ -86,10 +86,10 @@ fn subprojects_are_discovered() -> Result<()> {
     );
     assert!(projects
         .iter()
-        .any(|p| p.path == canonicalized_str(&root.path()) && p.build_tools == vec!["Cargo"]));
+        .any(|p| p.path == canonicalized_str(root.path()) && p.build_tools == vec!["Cargo"]));
     assert!(projects
         .iter()
-        .any(|p| p.path == canonicalized_str(&root.join("web")) && p.build_tools == vec!["NPM"]));
+        .any(|p| p.path == canonicalized_str(root.join("web")) && p.build_tools == vec!["NPM"]));
 
     Ok(())
 }
@@ -244,10 +244,10 @@ fn accepts_multiple_directories_as_input_and_deduplicates_by_path() -> Result<()
     );
     assert!(projects
         .iter()
-        .any(|p| p.path == canonicalized_str(&project_dir_1.path())));
+        .any(|p| p.path == canonicalized_str(project_dir_1.path())));
     assert!(projects
         .iter()
-        .any(|p| p.path == canonicalized_str(&project_dir_2.path())));
+        .any(|p| p.path == canonicalized_str(project_dir_2.path())));
 
     Ok(())
 }

tests/util/git.rs

@@ -15,7 +15,7 @@ where
     T: PathChild + AsRef<Path>,
 {
     fs::create_dir_all(parent.as_ref()).unwrap();
-    let repo = Repository::init(&parent).unwrap();
+    let repo = Repository::init(parent).unwrap();
 
     if !gitignore.is_empty() {
         let gitignore_path = parent.child(".gitignore");