Skip to content

Commit 94fe92d

Browse files
author
Georgi Djakov
committed
Merge branch 'icc-misc' into icc-next
* icc-misc interconnect: Do not create empty devres on missing interconnects interconnect: Move MODULE_DEVICE_TABLE next to the table itself dt-bindings: interconnect: qcom,sdm660: Disallow clocks when appropriate dt-bindings: interconnect: qcom,sm6115: Drop incorrect children if:then: block dt-bindings: interconnect: qcom,sm6115: Restrict children and clocks interconnect: qcom: Fix indentation interconnect: qcom: Restrict drivers per ARM/ARM64 Signed-off-by: Georgi Djakov <djakov@kernel.org>
2 parents 0d0a40e + 5b696f0 commit 94fe92d

5 files changed

Lines changed: 82 additions & 34 deletions

File tree

Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,19 @@ allOf:
7979
- const: aggre2_usb3_axi
8080
- const: cfg_noc_usb2_axi
8181

82+
- if:
83+
properties:
84+
compatible:
85+
enum:
86+
- qcom,sdm660-bimc
87+
- qcom,sdm660-cnoc
88+
- qcom,sdm660-gnoc
89+
- qcom,sdm660-snoc
90+
then:
91+
properties:
92+
clocks: false
93+
clock-names: false
94+
8295
examples:
8396
- |
8497
#include <dt-bindings/clock/qcom,gcc-sdm660.h>

Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -62,23 +62,33 @@ allOf:
6262
- if:
6363
properties:
6464
compatible:
65-
const: qcom,sm6115-cnoc
65+
const: qcom,sm6115-bimc
66+
then:
67+
properties:
68+
clocks: false
69+
clock-names: false
70+
patternProperties:
71+
'^interconnect-[a-z0-9]+$': false
6672

73+
- if:
74+
properties:
75+
compatible:
76+
const: qcom,sm6115-cnoc
6777
then:
6878
properties:
6979
clocks:
7080
items:
7181
- description: USB-NoC AXI clock
72-
7382
clock-names:
7483
items:
7584
- const: usb_axi
85+
patternProperties:
86+
'^interconnect-[a-z0-9]+$': false
7687

7788
- if:
7889
properties:
7990
compatible:
8091
const: qcom,sm6115-snoc
81-
8292
then:
8393
properties:
8494
clocks:
@@ -87,28 +97,13 @@ allOf:
8797
- description: UFS-NoC AXI clock.
8898
- description: USB-NoC AXI clock.
8999
- description: IPA clock.
90-
91100
clock-names:
92101
items:
93102
- const: cpu_axi
94103
- const: ufs_axi
95104
- const: usb_axi
96105
- const: ipa
97106

98-
- if:
99-
properties:
100-
compatible:
101-
enum:
102-
- qcom,sm6115-bimc
103-
- qcom,sm6115-clk-virt
104-
- qcom,sm6115-mmrt-virt
105-
- qcom,sm6115-mmnrt-virt
106-
107-
then:
108-
properties:
109-
clocks: false
110-
clock-names: false
111-
112107
unevaluatedProperties: false
113108

114109
examples:
@@ -149,4 +144,6 @@ examples:
149144
compatible = "qcom,sm6115-cnoc";
150145
reg = <0x01900000 0x8200>;
151146
#interconnect-cells = <1>;
147+
clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>;
148+
clock-names = "usb_axi";
152149
};

drivers/interconnect/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ struct icc_path *devm_of_icc_get(struct device *dev, const char *name)
432432
return ERR_PTR(-ENOMEM);
433433

434434
path = of_icc_get(dev, name);
435-
if (!IS_ERR(path)) {
435+
if (!IS_ERR_OR_NULL(path)) {
436436
*ptr = path;
437437
devres_add(dev, ptr);
438438
} else {

0 commit comments

Comments
 (0)