Skip to content

Commit 21785a9

Browse files
author
Shubham
committed
[PLAT-12293] Fix GCP provider creation for v1 APIs
Summary: v1 APIs don't have the construct for details, added the safe check for it to be present Test Plan: Tested GCP provider creation using v1 payload. Reviewers: vbansal Reviewed By: vbansal Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D31743
1 parent b245e5c commit 21785a9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

managed/src/main/java/com/yugabyte/yw/controllers/CloudProviderApiController.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -504,12 +504,13 @@ private JsonNode mayBeMassageRequest(JsonNode requestBody, Boolean forEdit) {
504504
// JSON object.
505505
ObjectMapper mapper = Json.mapper();
506506
ObjectNode details = (ObjectNode) requestBody.get("details");
507-
if (details.has("cloudInfo")) {
507+
if (details != null && details.has("cloudInfo")) {
508508
ObjectNode cloudInfo = (ObjectNode) details.get("cloudInfo");
509-
if (cloudInfo.has("gcp")) {
509+
if (cloudInfo != null && cloudInfo.has("gcp")) {
510510
ObjectNode gcpCloudInfo = (ObjectNode) cloudInfo.get("gcp");
511511
try {
512-
if (gcpCloudInfo.has("gceApplicationCredentials")
512+
if (gcpCloudInfo != null
513+
&& gcpCloudInfo.has("gceApplicationCredentials")
513514
&& !(gcpCloudInfo.get("gceApplicationCredentials").isTextual())) {
514515
gcpCloudInfo.put(
515516
"gceApplicationCredentials",

0 commit comments

Comments
 (0)