ata: sata_highbank: fix OF node reference leak in highbank_initialize_phys()

joehattori · gregkh · commit b8251050f551 · 2024-12-19T18:08:48.000+01:00
commit 676fe1f upstream. The OF node reference obtained by of_parse_phandle_with_args() is not released on early return. Add a of_node_put() call before returning. Fixes: 8996b89 ("ata: add platform driver for Calxeda AHCI controller") Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
@@ -348,6 +348,7 @@ static int highbank_initialize_phys(struct device *dev, void __iomem *addr)
 			phy_nodes[phy] = phy_data.np;
 			cphy_base[phy] = of_iomap(phy_nodes[phy], 0);
 			if (cphy_base[phy] == NULL) {
+				of_node_put(phy_data.np);
 				return 0;
 			}
 			phy_count += 1;

Original file line number	Diff line number	Diff line change
`@@ -348,6 +348,7 @@ static int highbank_initialize_phys(struct device dev, void __iomem addr)`
`348`	`348`	`phy_nodes[phy] = phy_data.np;`
`349`	`349`	`cphy_base[phy] = of_iomap(phy_nodes[phy], 0);`
`350`	`350`	`if (cphy_base[phy] == NULL) {`
	`351`	`+ of_node_put(phy_data.np);`
`351`	`352`	`return 0;`
`352`	`353`	`}`
`353`	`354`	`phy_count += 1;`