lava: Install the kselftest tarball using an overlay #2840
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not seeing this take effect in the staging run that's currently got jobs in my lab: https://lava.sirena.org.uk/scheduler/job/1283336/definition - not sure what's going on there? |
a-wai
approved these changes
Jul 23, 2025
|
Let's try to test it again on staging. I remember last time i tried and failed, but we should try again. |
|
issues review meeting: |
Currently the kselftest LAVA jobs that KernelCI generates have the test job download the kselftest tarball onto the device. This has a couple of disadvantages: - Any caching that is configured for the LAVA worker will be bypassed, increasing network traffic both for the lab and for the KernelCI storage server. - The entire kselftest tarball has to be downloaded onto the test system, and if (as is usual) it is a NFS filesystem then an uncompressed copy written over the network to the LAVA worker. The test-definitions integration for kselftest also supports running a copy that is already installed in the filesystem, and LAVA supports adding files onto the root filesystem via it's overlay mechanism, so we can avoid the overheads of downloading directly to the device by having LAVA apply the kselftest tarball to the root filesystem as an overlay instead. A commit was previously merged doing this for the legacy LAVA templates, this updates the Maestro ones. Signed-off-by: Mark Brown <broonie@kernel.org>
broonie
force-pushed
the
kselftest-overlay
branch
from
c973448 to
8eb3d5c
Compare
The devices/error_logs kselftest isn't really a test per se, more it's something that exists to report errors generated by other tests. Let's take advantage of that (and the fact that we are overlaying the kselftest tarball unconditionally at the minute) by running it at the end of each test job. Signed-off-by: Mark Brown <broonie@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the kselftest LAVA jobs that KernelCI generates have the test
job download the kselftest tarball onto the device. This has a couple
of disadvantages:
increasing network traffic both for the lab and for the KernelCI
storage server.
system, and if (as is usual) it is a NFS filesystem then an
uncompressed copy written over the network to the LAVA worker.
The test-definitions integration for kselftest also supports running a
copy that is already installed in the filesystem, and LAVA supports
adding files onto the root filesystem via it's overlay mechanism, so we
can avoid the overheads of downloading directly to the device by having
LAVA apply the kselftest tarball to the root filesystem as an overlay
instead.
A commit was previously merged doing this for the legacy LAVA templates,
this updates the Maestro ones.
Signed-off-by: Mark Brown broonie@kernel.org