firecracker: stop sending network_overrides on snapshot load

Author: cursoragent

lib/hypervisor/firecracker/config.go

@@ -67,11 +67,10 @@ type snapshotCreateParams struct {
 }
 
 type snapshotLoadParams struct {
-	MemFilePath         string            `json:"mem_file_path,omitempty"`
-	SnapshotPath        string            `json:"snapshot_path"`
-	EnableDiffSnapshots bool              `json:"enable_diff_snapshots,omitempty"`
-	ResumeVM            bool              `json:"resume_vm,omitempty"`
-	NetworkOverrides    []networkOverride `json:"network_overrides,omitempty"`
+	MemFilePath         string `json:"mem_file_path,omitempty"`
+	SnapshotPath        string `json:"snapshot_path"`
+	EnableDiffSnapshots bool   `json:"enable_diff_snapshots,omitempty"`
+	ResumeVM            bool   `json:"resume_vm,omitempty"`
 }
 
 type networkOverride struct {
@@ -187,13 +186,12 @@ func toSnapshotCreateParams(snapshotDir string) snapshotCreateParams {
 	}
 }
 
-func toSnapshotLoadParams(snapshotDir string, networkOverrides []networkOverride) snapshotLoadParams {
+func toSnapshotLoadParams(snapshotDir string, _ []networkOverride) snapshotLoadParams {
 	return snapshotLoadParams{
 		MemFilePath:         snapshotMemoryPath(snapshotDir),
 		SnapshotPath:        snapshotStatePath(snapshotDir),
 		EnableDiffSnapshots: true,
 		ResumeVM:            false,
-		NetworkOverrides:    networkOverrides,
 	}
 }
 

lib/hypervisor/firecracker/config_test.go

@@ -1,6 +1,7 @@
 package firecracker
 
 import (
+	"encoding/json"
 	"testing"
 
 	"github.com/kernel/hypeman/lib/hypervisor"
@@ -71,5 +72,7 @@ func TestSnapshotParamPaths(t *testing.T) {
 	assert.Equal(t, "/tmp/snapshot-latest/memory", load.MemFilePath)
 	assert.True(t, load.EnableDiffSnapshots)
 	assert.False(t, load.ResumeVM)
-	require.Len(t, load.NetworkOverrides, 1)
+	loadJSON, err := json.Marshal(load)
+	require.NoError(t, err)
+	assert.NotContains(t, string(loadJSON), "network_overrides")
 }