Skip to content

Commit ec9f637

Browse files
laoarKernel Patches Daemon
authored and
Kernel Patches Daemon
committed
selftests/bpf: Add selftest for sleepable bpf_task_under_cgroup()
The result as follows, $ tools/testing/selftests/bpf/test_progs --name=task_under_cgroup #237 task_under_cgroup:OK Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED And no error messages in dmesg. Without the prev patch, there will be RCU warnings in dmesg. Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Acked-by: Stanislav Fomichev <sdf@google.com>
1 parent 358bc77 commit ec9f637

File tree

2 files changed

+33
-3
lines changed

2 files changed

+33
-3
lines changed

tools/testing/selftests/bpf/prog_tests/task_under_cgroup.c

+6-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,12 @@ void test_task_under_cgroup(void)
3030
if (!ASSERT_OK(ret, "test_task_under_cgroup__load"))
3131
goto cleanup;
3232

33-
ret = test_task_under_cgroup__attach(skel);
34-
if (!ASSERT_OK(ret, "test_task_under_cgroup__attach"))
33+
skel->links.lsm_run = bpf_program__attach_lsm(skel->progs.lsm_run);
34+
if (!ASSERT_OK_PTR(skel->links.lsm_run, "attach_lsm"))
35+
goto cleanup;
36+
37+
skel->links.tp_btf_run = bpf_program__attach_trace(skel->progs.tp_btf_run);
38+
if (!ASSERT_OK_PTR(skel->links.tp_btf_run, "attach_tp_btf"))
3539
goto cleanup;
3640

3741
pid = fork();

tools/testing/selftests/bpf/progs/test_task_under_cgroup.c

+27-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const volatile __u64 cgid;
1818
int remote_pid;
1919

2020
SEC("tp_btf/task_newtask")
21-
int BPF_PROG(handle__task_newtask, struct task_struct *task, u64 clone_flags)
21+
int BPF_PROG(tp_btf_run, struct task_struct *task, u64 clone_flags)
2222
{
2323
struct cgroup *cgrp = NULL;
2424
struct task_struct *acquired;
@@ -48,4 +48,30 @@ int BPF_PROG(handle__task_newtask, struct task_struct *task, u64 clone_flags)
4848
return 0;
4949
}
5050

51+
SEC("lsm.s/bpf")
52+
int BPF_PROG(lsm_run, int cmd, union bpf_attr *attr, unsigned int size)
53+
{
54+
struct cgroup *cgrp = NULL;
55+
struct task_struct *task;
56+
int ret = 0;
57+
58+
task = bpf_get_current_task_btf();
59+
if (local_pid != task->pid)
60+
return 0;
61+
62+
if (cmd != BPF_LINK_CREATE)
63+
return 0;
64+
65+
/* 1 is the root cgroup */
66+
cgrp = bpf_cgroup_from_id(1);
67+
if (!cgrp)
68+
goto out;
69+
if (!bpf_task_under_cgroup(task, cgrp))
70+
ret = -1;
71+
bpf_cgroup_release(cgrp);
72+
73+
out:
74+
return ret;
75+
}
76+
5177
char _license[] SEC("license") = "GPL";

0 commit comments

Comments
 (0)