Skip to content

Commit ca478d8

Browse files
ukleinekUwe Kleine-König
authored andcommitted
pwm: pca9685: Don't disable hardware in .free()
It's the responsibility of the consumer to disable the hardware before it's released. And there are use cases where it's beneficial to keep the PWM on, e.g. to keep a backlight on before kexec()ing into a new kernel. Even if it would be considered right to disable on pwm_put(), this should be done in the core and not each individual driver. So drop the hardware access in .free(). Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Link: https://lore.kernel.org/r/1ee1a514aeb5f0effafa2d6ec91bc54130895cd9.1753784092.git.u.kleine-koenig@baylibre.com Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
1 parent d8af381 commit ca478d8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/pwm/pwm-pca9685.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,6 @@ static void pca9685_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
497497
struct pca9685 *pca = to_pca(chip);
498498

499499
mutex_lock(&pca->lock);
500-
pca9685_pwm_set_duty(chip, pwm->hwpwm, 0);
501500
clear_bit(pwm->hwpwm, pca->pwms_enabled);
502501
mutex_unlock(&pca->lock);
503502

0 commit comments

Comments
 (0)