Skip to content

Commit c2d24cd

Browse files
Pu LehuiKernel Patches Daemon
authored andcommitted
selftests/bpf: Skip test when perf_event_open returns EOPNOTSUPP
When testing send_signal and stacktrace_build_id_nmi using the riscv sbi pmu driver without the sscofpmf extension or the riscv legacy pmu driver, they encountered failures as follows: test_send_signal_common:FAIL:perf_event_open unexpected perf_event_open: actual -1 < expected 0 #272/3 send_signal/send_signal_nmi:FAIL test_stacktrace_build_id_nmi:FAIL:perf_event_open err -1 errno 95 #304 stacktrace_build_id_nmi:FAIL The reason is that the above pmu driver or hardware does not support sampling events, that is, PERF_PMU_CAP_NO_INTERRUPT is set to pmu capabilities, and then perf_event_open returns EOPNOTSUPP. Since PERF_PMU_CAP_NO_INTERRUPT is not only set in the riscv-related pmu driver, it is better to skip testing when this capability is set. Signed-off-by: Pu Lehui <pulehui@huawei.com>
1 parent 3db8025 commit c2d24cd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tools/testing/selftests/bpf/prog_tests/send_signal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ static void test_send_signal_nmi(bool signal_thread)
179179
pmu_fd = syscall(__NR_perf_event_open, &attr, 0 /* pid */,
180180
-1 /* cpu */, -1 /* group_fd */, 0 /* flags */);
181181
if (pmu_fd == -1) {
182-
if (errno == ENOENT) {
182+
if (errno == ENOENT || errno == EOPNOTSUPP) {
183183
printf("%s:SKIP:no PERF_COUNT_HW_CPU_CYCLES\n",
184184
__func__);
185185
test__skip();

tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ void test_stacktrace_build_id_nmi(void)
3535
pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
3636
0 /* cpu 0 */, -1 /* group id */,
3737
0 /* flags */);
38-
if (pmu_fd < 0 && errno == ENOENT) {
38+
if (pmu_fd < 0 && (errno == ENOENT || errno == EOPNOTSUPP)) {
3939
printf("%s:SKIP:no PERF_COUNT_HW_CPU_CYCLES\n", __func__);
4040
test__skip();
4141
goto cleanup;

0 commit comments

Comments
 (0)