Skip to content

Commit 46012a7

Browse files
kjain101Nobody
authored andcommitted
bpf: Enable bpf support for reading branch records in powerpc
Branch data available to bpf programs can be very useful to get stack traces out of userspace applications. Commit fff7b64 ("bpf: Add bpf_read_branch_records() helper") added bpf support to capture branch records in x86. Enable this feature for powerpc as well. Commit 67306f8 ("selftests/bpf: Add bpf_read_branch_records() selftest") adds selftest corresponding to bpf branch read function bpf_read_branch_records(). Used this selftest to test bpf support, for reading branch records in powerpc. Selftest result in power9 box before this patch changes: [command]# ./test_progs -t perf_branches Failed to load bpf_testmod.ko into the kernel: -8 WARNING! Selftests relying on bpf_testmod.ko will be skipped. test_perf_branches_common:PASS:test_perf_branches_load 0 nsec test_perf_branches_common:PASS:attach_perf_event 0 nsec test_perf_branches_common:PASS:set_affinity 0 nsec check_good_sample:PASS:output not valid 0 nsec check_good_sample:FAIL:read_branches_size err -2 check_good_sample:FAIL:read_branches_stack err -2 check_good_sample:FAIL:read_branches_stack stack bytes written=-2 not multiple of struct size=24 check_good_sample:FAIL:read_branches_global err -2 check_good_sample:FAIL:read_branches_global global bytes written=-2 not multiple of struct size=24 check_good_sample:PASS:read_branches_size 0 nsec #75/1 perf_branches_hw:FAIL #75/2 perf_branches_no_hw:OK #75 perf_branches:FAIL Summary: 0/1 PASSED, 0 SKIPPED, 2 FAILED Selftest result in power9 box after this patch changes: [command]#: ./test_progs -t perf_branches #75/1 perf_branches_hw:OK #75/2 perf_branches_no_hw:OK #75 perf_branches:OK Summary: 1/2 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Kajol Jain<kjain@linux.ibm.com>
1 parent 3b47f71 commit 46012a7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/trace/bpf_trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1404,7 +1404,7 @@ static const struct bpf_func_proto bpf_perf_prog_read_value_proto = {
14041404
BPF_CALL_4(bpf_read_branch_records, struct bpf_perf_event_data_kern *, ctx,
14051405
void *, buf, u32, size, u64, flags)
14061406
{
1407-
#ifndef CONFIG_X86
1407+
#if !(defined(CONFIG_X86) || defined(CONFIG_PPC64))
14081408
return -ENOENT;
14091409
#else
14101410
static const u32 br_entry_size = sizeof(struct perf_branch_entry);

0 commit comments

Comments
 (0)