Skip to content

Commit 861ad74

Browse files
nkovela1tensorflower-gardener
authored andcommitted
Adds error for serializing metric using layer serialization.
PiperOrigin-RevId: 527991285
1 parent 1b7c53d commit 861ad74

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

keras/layers/serialization.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
from keras.layers.rnn import cell_wrappers
5151
from keras.layers.rnn import gru
5252
from keras.layers.rnn import lstm
53+
from keras.metrics import base_metric
5354
from keras.saving import serialization_lib
5455
from keras.saving.legacy import serialization as legacy_serialization
5556
from keras.saving.legacy.saved_model import json_utils
@@ -208,6 +209,13 @@ def serialize(layer, use_legacy_format=False):
208209
pprint(tf.keras.layers.serialize(model))
209210
# prints the configuration of the model, as a dict.
210211
"""
212+
if isinstance(layer, base_metric.Metric):
213+
raise ValueError(
214+
f"Cannot serialize {layer} since it is a metric. "
215+
"Please use the `keras.metrics.serialize()` and "
216+
"`keras.metrics.deserialize()` APIs to serialize "
217+
"and deserialize metrics."
218+
)
211219
if use_legacy_format:
212220
return legacy_serialization.serialize_keras_object(layer)
213221

keras/layers/serialization_test.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from keras.layers.rnn import gru_v1
2525
from keras.layers.rnn import lstm
2626
from keras.layers.rnn import lstm_v1
27+
from keras.metrics import Mean
2728
from keras.testing_infra import test_combinations
2829

2930

@@ -191,6 +192,11 @@ def test_serialize_deserialize_gru(self, layer):
191192
self.assertIsInstance(new_layer, gru_v1.GRU)
192193
self.assertNotIsInstance(new_layer, gru.GRU)
193194

195+
def test_serialize_metric_throws_error(self):
196+
metric = Mean()
197+
with self.assertRaisesRegex(ValueError, "since it is a metric."):
198+
_ = keras.layers.serialize(metric)
199+
194200

195201
if __name__ == "__main__":
196202
tf.test.main()

0 commit comments

Comments
 (0)