Add dockerfile to run the server and ensure it works in the CI #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
May 13, 2020
Closed
pedro823
reviewed
May 13, 2020
Co-authored-by: Pedro Pereira <grey.pedrinho@gmail.com>
|
I believe we can merge this because it adds quite some value to the repo, and we can open an issue to track the compatibility of keras-io with pygments >= 2.5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pinned the versions of the packages which I consider "dangerous" to upgrade automatically. We can always bump a version if needed in a pull request. I think we're exposed to breakages if it gets updated automatically in master.
We have an issue with comments tags in HTML, you can see it in the docker build, so the problem is unrelated to this pull request.