Skip to content

Loosen class requirements in from_preset #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Loosen class requirements in from_preset #2276

wants to merge 1 commit into from

Conversation

mattdangerw
Copy link
Member

  • Push all the preset loading logic to the preset loader class.
  • Loosen restrictions on what tokenizers/image converts can be loaded with what backbones.
  • Fix some bugs with converters.
  • Pass user kwargs around explicitly as dicts instead of using **kwargs everywhere (which is less safe).

@mattdangerw
Loosen class requirements in from_preset
55cd4a8 
* Push all the preset loading logic to the preset loader class.
* Loosen restrictions on what tokenizers/image converts can be loaded with what
  backbones.
* Fix some bugs with converters.
* Pass user kwargs around explicitly as dicts instead of using **kwargs
  everywhere (which is less safe).
@mattdangerw
Copy link
Member Author

This will probably have some failing tests, just seeing how it does. Need to add some unit tests for a few bug I spotted in our converters still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattdangerw