Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalization layer gets retraced on every call (even without any operations inside augment_image) #477

Closed
quantumalaviya opened this issue Jun 8, 2022 · 5 comments

Comments

@quantumalaviya
Copy link
Contributor

I discovered this problem with equalization while trying to add changes for my AugMix PR. It was already known that the Equalization layer gets retraced on every call. While trying to find the reason, I realized how this problem persists even when all operations inside augment_image are removed (i.e. augment_image simply returns the input). This seems to be an issue with BaseImageAugmentationLayer. The strange part is that some of the other layers I tested (FourierMix, Posterization, and Solarization) don't share this issue.

Steps to reproduce:
Edit the Equalization.augment_image function to:

    def augment_image(self, image, transformation=None):
        return image

and call the layer multiple times (I just used a loop to repeatedly called it on the same image batch)

@bhack
Copy link
Contributor

bhack commented Jun 8, 2022

Can we close this now?

@LukeWood
Copy link
Contributor

LukeWood commented Jun 9, 2022

No, it still gets retraced. I think we fixed the dynamic shape issue, not retracing issue (the PR was improperly titled)

We need to verify the retracing issue is fixed.

@sebastian-sz
Copy link
Contributor

I think this could be related to: #241

@bhack
Copy link
Contributor

bhack commented Jun 9, 2022

@sebastian-sz Yes as we had a quite detailed analisys there I don't know if we Need also this one.

@quantumalaviya
Copy link
Contributor Author

I think this can be closed @LukeWood

#241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants