Skip to content

Conversation

@Hermione2408
Copy link
Member

To start keploy server from typescript sdk for all OS.

feat keploy/keploy#352

To start keploy server from typescript sdk for all OS.

feat #352

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Added additional check for error code and will also start the server in that case too

feature #352

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408
Copy link
Member Author

@re-Tick Can you please review this PR?

@re-Tick
Copy link
Contributor

re-Tick commented Apr 7, 2023

When I try the changes with a sample application, the following error is thrown:

Error checking port: Command failed: lsof -i:6789

@Hermione2408
Copy link
Member Author

I am checking why it is happening

@Hermione2408
Copy link
Member Author

@re-Tick error is occurring because when there is nothing running on port 6789 , empty output is treated as an error and hence the error is shown, I have added additional check for the error code and will also start the server in that case too

@re-Tick
Copy link
Contributor

re-Tick commented Apr 10, 2023

@Hermione2408 changes are working locally. LGTM.

@re-Tick re-Tick added Don't Merge Not to be merged until gsoc results Accepted PR is reviewed and Accepted labels Apr 10, 2023
@keploy
Copy link

keploy bot commented Apr 15, 2025

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

1 similar comment
@keploy-staging
Copy link

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants