Skip to content

Conversation

@imdeveshshukla
Copy link

@imdeveshshukla imdeveshshukla commented Oct 22, 2025

What has changed?

Adjusted the heading style for the “✨ AI Suggested Sample Apps” section in QuickstartFilter.js to improve mobile responsiveness.
The headingStyle object now dynamically adjusts marginLeft and fontSize based on the screen width (using window.innerWidth < 480).

This ensures that the header text is properly spaced and sized on smaller devices without affecting the desktop layout.

This PR Resolves #2987

Type of change

  • Bug fix (non-breaking change which fixes an issue).

How Has This Been Tested?

  • run npm run build and npm run serve to check if the changes are working as expected

Before: Header appeared slightly left-cramped and oversized on mobile.
image

After: Header spacing and font size adjust automatically for better readability.
image

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

Copilot AI review requested due to automatic review settings October 22, 2025 21:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves mobile responsiveness of the "✨ AI Suggested Sample Apps" heading in QuickstartFilter.js by making the heading style dynamically adjust based on screen width. The changes reduce margin and font size on mobile devices (< 480px) for better spacing and readability.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imdeveshshukla can you please share a video it will be easy for us to review, also please fix the lint and DCO issues

@imdeveshshukla imdeveshshukla force-pushed the main branch 2 times, most recently from 78ec824 to 5d2f3b7 Compare October 23, 2025 19:09
@imdeveshshukla
Copy link
Author

Recording.2025-10-24.004618.mp4

@Achanandhi-M

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imdeveshshukla can you please fix the copilot suggestions and also please fix the lint issue

@imdeveshshukla
Copy link
Author

Hi @Achanandhi-M, I’ve already fixed the Copilot suggestions and addressed the lint issues. Hopefully, everything should be resolved now. 😊

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imdeveshshukla, this PR looks like it’s mainly a styling issue, right? Could you please explain why we need to use useEffect for this change?

Also please fix the lint issue

Signed-off-by: Devesh Shukla <93655594+imdeveshshukla@users.noreply.github.com>
@imdeveshshukla
Copy link
Author

imdeveshshukla commented Oct 27, 2025

@Achanandhi-M
I used a small custom hook useMediaQuery (which internally uses useEffect) to detect screen width changes dynamically. The reason for using this approach is that it allows the component to reactively update styles at runtime while keeping the existing inline style structure (headingStyle)
if you prefer, I can switch to another approach such as using Tailwind’s responsive utilities or simple CSS media queries to handle responsiveness in a cleaner way. Please let me know what you’d recommend.

I’ve also updated the commit message, so the previous linting error should now be resolved. Please let me know if there’s anything else that needs adjustment.

@Achanandhi-M
Copy link
Contributor

@Achanandhi-M I used a small custom hook useMediaQuery (which internally uses useEffect) to detect screen width changes dynamically. The reason for using this approach is that it allows the component to reactively update styles at runtime while keeping the existing inline style structure (headingStyle) if you prefer, I can switch to another approach such as using Tailwind’s responsive utilities or simple CSS media queries to handle responsiveness in a cleaner way. Please let me know what you’d recommend.

I’ve also updated the commit message, so the previous linting error should now be resolved. Please let me know if there’s anything else that needs adjustment.

@imdeveshshukla A simple media query works fine, and also fix the linter issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix]: styling of AI suggested sample apps in mobile navigation screen (docs website)

2 participants