Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional meraki bw limit info #718

Closed
Rajupln917 opened this issue Jun 26, 2024 · 2 comments · Fixed by #726
Closed

Adding optional meraki bw limit info #718

Rajupln917 opened this issue Jun 26, 2024 · 2 comments · Fixed by #726

Comments

@Rajupln917
Copy link

Rajupln917 commented Jun 26, 2024

When we try to set the preference provided in the below issue, it completely stopped reporting data for that Meraki org with no errors in the logs.

preferences:
show_uplink_bandwidth_limits: true

Issue refernce link: #686

Please check on this.

@i3149
Copy link
Contributor

i3149 commented Jul 17, 2024

The problem here is that this call is per network, not per organization like all of the others. This means iterating over all the networks you have while respecting the API timing limits meraki enforces. End result is that things can take a long time when there are a non trivial number of networks to go over.

Looking at the code, there's a cache so that subsequent calls will be fast, but the first time around will take a long time and block results, which is what you are seeing. Let me try to have it load the data in the background without blocking results. Then when the data is set, it will show up in the results. Seem resonable?

@Rajupln917
Copy link
Author

Rajupln917 commented Jul 17, 2024

Yes, that helps! If you can shift the data load to the background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants