Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve integrity of specs in emit_sql.py functions and fields #882

Open
bojanserafimov opened this issue Jul 16, 2020 · 0 comments
Open

Improve integrity of specs in emit_sql.py functions and fields #882

bojanserafimov opened this issue Jul 16, 2020 · 0 comments
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.

Comments

@bojanserafimov
Copy link
Collaborator

A few hasty PRs have broken some of the function and field specs in this module. We should fix that to have a higher confidence in correctness, and to allow implementation of new features without risk.

Some examples:

  • _aliases field that doesn't only store aliases anymore
  • The concept of used_columns is loosely defined but a lot relies on it
@bojanserafimov bojanserafimov added the maintainer quality-of-life Features that ease development, but are not necessarily visible to package users. label Jul 16, 2020
@bojanserafimov bojanserafimov self-assigned this Jul 16, 2020
@bojanserafimov bojanserafimov mentioned this issue Jul 16, 2020
Merged
@bojanserafimov bojanserafimov removed their assignment Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bojanserafimov