Skip to content

Commit c48c5c0

Browse files
committed
fix accessibility issue
1 parent c728564 commit c48c5c0

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

css/style.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@ body {
159159
fill: #6d7f97;
160160
background-color: #ecf2f8;
161161
padding: 0.4rem 0.8rem;
162-
border-radius: 50%; }
162+
border-radius: 50%;
163+
cursor: pointer; }
163164
@media (min-width: 768px) {
164165
.card__info-icon-share:hover {
165166
fill: #ecf2f8;

index.html

+4-6
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,12 @@ <h1 class="card__heading">
8989
</a>
9090
</div>
9191

92-
<a
92+
<span
9393
href="#"
9494
class="
9595
card__info-icon card__info-icon-share--active
9696
js-share-icon
9797
"
98-
aria-label="SVG icon"
9998
>
10099
<svg
101100
xmlns="http://www.w3.org/2000/svg"
@@ -106,20 +105,19 @@ <h1 class="card__heading">
106105
d="M15 6.495L8.766.014V3.88H7.441C3.33 3.88 0 7.039 0 10.936v2.049l.589-.612C2.59 10.294 5.422 9.11 8.39 9.11h.375v3.867L15 6.495z"
107106
/>
108107
</svg>
109-
</a>
108+
</span>
110109
</div>
111110

112-
<a
111+
<span
113112
href="#"
114113
class="card__info-icon card__info-icon-share js-share-icon"
115-
aria-label="SVG icon"
116114
>
117115
<svg xmlns="http://www.w3.org/2000/svg" width="15" height="13">
118116
<path
119117
d="M15 6.495L8.766.014V3.88H7.441C3.33 3.88 0 7.039 0 10.936v2.049l.589-.612C2.59 10.294 5.422 9.11 8.39 9.11h.375v3.867L15 6.495z"
120118
/>
121119
</svg>
122-
</a>
120+
</span>
123121
</div>
124122
</div>
125123
</figure>

scss/_components.scss

+1
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@
168168
background-color: $color-secondary;
169169
padding: 0.4rem 0.8rem;
170170
border-radius: 50%;
171+
cursor: pointer;
171172

172173
@media (min-width: 768px) {
173174
&:hover {

0 commit comments

Comments
 (0)