Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify winston compatibility #79

Open
henhal opened this issue Jun 25, 2018 · 1 comment
Open

Clarify winston compatibility #79

henhal opened this issue Jun 25, 2018 · 1 comment

Comments

@henhal
Copy link

henhal commented Jun 25, 2018

I've been using winston-papertrail with winston 1.1.2 for some time, working fine.
However, a module requiring winston 2.1.1 resulted in winston.transports not being assigned Papertrail as a transport. It seems to work to use the returned constructor from winston-papertrail directly, it seems only the injection of winston.transports.Papertrail as the constructor seems to fail.

I saw another issue about winston 3.0 breaking changes, but is it known/expected that winston-papertrail also breaks with 2.x?

@markdascher
Copy link
Collaborator

It should definitely work in winston 2.1.1, and I just tested that exact version. No problems using new winston.transports.Papertrail. And this has been there from the beginning, so even an older version of winston-papertrail should be fine.

Is it possible that two different versions of winston are being used simultaneously? If the module has its own private copy of 2.1.1 then I could imagine some weirdness like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants