Skip to content

Commit 4139c0a

Browse files
authored
Rollup merge of rust-lang#48051 - ollie27:rustdoc_fn_unit_return, r=QuietMisdreavus
rustdoc: Hide `-> ()` in cross crate inlined Fn* bounds
2 parents c04ec2c + 528d6b6 commit 4139c0a

File tree

3 files changed

+43
-1
lines changed

3 files changed

+43
-1
lines changed

src/librustdoc/clean/simplify.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ pub fn where_clauses(cx: &DocContext, clauses: Vec<WP>) -> Vec<WP> {
106106
}
107107
PP::Parenthesized { ref mut output, .. } => {
108108
assert!(output.is_none());
109-
*output = Some(rhs.clone());
109+
if *rhs != clean::Type::Tuple(Vec::new()) {
110+
*output = Some(rhs.clone());
111+
}
110112
}
111113
};
112114
true
+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
pub fn f2<F: FnMut(u32) + Clone>(f: F) {}
12+
13+
pub fn f3<F: FnMut(u64) -> () + Clone>(f: F) {}

src/test/rustdoc/unit-return.rs

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
// aux-build:unit-return.rs
12+
13+
#![crate_name = "foo"]
14+
15+
extern crate unit_return;
16+
17+
// @has 'foo/fn.f0.html' '//*[@class="rust fn"]' 'F: FnMut(u8) + Clone'
18+
pub fn f0<F: FnMut(u8) + Clone>(f: F) {}
19+
20+
// @has 'foo/fn.f1.html' '//*[@class="rust fn"]' 'F: FnMut(u16) + Clone'
21+
pub fn f1<F: FnMut(u16) -> () + Clone>(f: F) {}
22+
23+
// @has 'foo/fn.f2.html' '//*[@class="rust fn"]' 'F: FnMut(u32) + Clone'
24+
pub use unit_return::f2;
25+
26+
// @has 'foo/fn.f3.html' '//*[@class="rust fn"]' 'F: FnMut(u64) + Clone'
27+
pub use unit_return::f3;

0 commit comments

Comments
 (0)