Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban board Project #13

Open
kennyegun24 opened this issue Feb 21, 2023 · 3 comments
Open

Kanban board Project #13

kennyegun24 opened this issue Feb 21, 2023 · 3 comments

Comments

@kennyegun24
Copy link
Owner

In this project we are a team of two , kindly find the project link attached below
https://github.com/users/kennyegun24/projects/8

@FrederickMih
Copy link

Hi 🙋 @kennyegun24, @jaamanu ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 🟢 🟢 🟢

  • Tasks are distributed in a fair manner ✔️

Required Changes ♻️

  • It seems the column In Review is missing from your Board. As stated in our requirements, let's kindly add the column.

  • as stated in the requirements of this project, we shall kindly ensure that each task has a description
    Capture

  • Please kindly make sure that each card contains the complete requirements, not just the first line as you have done in some cases.

From requirements 👍 Yours
Capture Capture

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@t-yanick
Copy link

Hi @kennyegun24 and @jaamanu ,

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

  • As indicated by previous reviewer, your Kaban board is missing the In Review column. Kindly add this column.
    Screen Shot 2023-02-21 at 5 44 42 AM

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@GzimAsani
Copy link

STATUS: APPROVED 💯

There is nothing else to say than it's time to merge... 🥳

Cheers and Happy coding! 👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Please be reminded to not open a new pull request after you get a review, only use the same one 💭

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants