Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why addressing html *and* body? #14

Open
isellsoap opened this issue Aug 29, 2014 · 3 comments
Open

Why addressing html *and* body? #14

isellsoap opened this issue Aug 29, 2014 · 3 comments
Labels
question

Comments

@isellsoap
Copy link

Why do you address both the html and the body element for the root styles? Shouldn’t it be sufficient specifying just one of them?
@kennethormandy
Copy link
Owner

Hey, thanks for opening an issue. It’s possible (though unlikely) that something may exist outside the body, so I’ve been in the habit of always addressing both:

<!-- … -->
</head>
<pre>Error: something might show up here</pre>
<body>
<h1>Hello, world</h1>
<!-- … -->

It’s also more relevant in this project since the font-feature-settings styles might not cascade as expected.

If it’s causing problems for you, please let me know and I’d be happy to address it!

@kpeatt
Copy link
Contributor

kpeatt commented Sep 18, 2014

@kennethormandy Wouldn't html capture both in that situation? Why address the two?

@isellsoap
Copy link
Author

@kennethormandy You first example is invalid HTML. Why would you want to target such invalid use cases? If someone writes such markup they don’t deserve to be blessed with opentype features. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kpeatt @isellsoap @kennethormandy