Add Go linting Action and fix results #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just try running docker compose build Try building individual cadence containrs disable dockerhub login Try to build containers delete other workflows Try consolidating workflows Add codeql scan Add working directory Fix go version Remove pr branch Add go linter action
kenellorando
force-pushed
the
lintactions
branch
from
506966b
to
7a11b1e
Compare
Check all returned errors
kenellorando
force-pushed
the
lintactions
branch
from
18df149
to
bd05f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the repository's first Github Action, which lints all Go code under
cadence/serverfor all pull requests tomaster. It additionally fixes the linter's suggestions that we handle anyw.Writeerrors, which are now logged.