Skip to content

Commit da66d5b

Browse files
committed
move assertions out of try finally block
1 parent df51255 commit da66d5b

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

djangojs/tests/test_urls.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,14 @@ def test_urls_disabled(self):
176176
@override_settings(JS_CACHE_DURATION=0)
177177
def test_force_script_name(self):
178178
from django.core.urlresolvers import set_script_prefix, clear_script_prefix
179-
set_script_prefix("/force_script")
180-
self.result = self.get_result() # To take override_settings in account
181-
self.assertEqual(self.result['django_js_urls'], '/force_script/djangojs/urls')
182-
clear_script_prefix()
183179

180+
try:
181+
set_script_prefix("/force_script")
182+
self.result = self.get_result() # To take override_settings in account
183+
finally:
184+
clear_script_prefix()
185+
186+
self.assertEqual(self.result['django_js_urls'], '/force_script/djangojs/urls')
184187

185188
class UrlsAsDictTest(UrlsTestMixin, TestCase):
186189

@@ -216,7 +219,8 @@ def test_force_script_name(self):
216219
url = reverse('django_js_urls')
217220
set_script_prefix("/force_script")
218221
response = self.client.get(url)
219-
result = json.loads(response.content.decode())
220-
self.assertEqual(result['django_js_urls'], '/force_script/djangojs/urls')
221222
finally:
222223
clear_script_prefix()
224+
225+
result = json.loads(response.content.decode())
226+
self.assertEqual(result['django_js_urls'], '/force_script/djangojs/urls')

0 commit comments

Comments
 (0)