Skip to content

Commit adf54b2

Browse files
authored
Merge pull request swiftlang#582 from Teemperor/AddDestructorCallOverriden
[lldb][NFC] Fix call-overridden-method test by adding virtual destructor
2 parents e731461 + 0c5d861 commit adf54b2

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ def test_call_on_base(self):
4545
# Test calling the base class.
4646
self.expect("expr realbase.foo()", substrs=["= 1"])
4747

48-
@skipIfLinux # Returns wrong result code on some platforms.
49-
@expectedFailureAll(archs=['arm64', 'arm64e'], bugnumber="<rdar://problem/56828233>")
5048
def test_call_on_derived(self):
5149
"""Test calls to overridden methods in derived classes."""
5250
self.build()
@@ -64,7 +62,6 @@ def test_call_on_derived(self):
6462
# a vtable entry that does not exist in the compiled program).
6563
self.expect("expr d.foo()", substrs=["= 2"])
6664

67-
@skipIfLinux # Calling constructor causes SIGABRT
6865
@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr43707")
6966
def test_call_on_temporary(self):
7067
"""Test calls to overridden methods in derived classes."""

lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/main.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ class Base {
66

77
class Derived : public Base {
88
public:
9+
virtual ~Derived() {}
910
virtual int foo() { return 2; }
1011
};
1112

0 commit comments

Comments
 (0)