Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildifier check and fix fails silently on linux with --noenable_runfiles #91

Open
peakschris opened this issue Jul 1, 2024 · 0 comments

Comments

@peakschris
Copy link

Without runfiles, buildifier check and fix fails silently. The command has no output or errors. It would be good at least to error in this case, if norunfiles mode will not be supported.

This issue can be covered by the test case in #90 if linux platform is enabled for the norunfiles cases.

To reproduce:

> git clone
> cd buildifier_prebuilt/examples/simple
> BUILD <-- make some edits to BUILD, breaking its formatting
> export BUILDIFIER_DIFF=diff
> bazel run //:buildifier.check --noenable_runfiles

outputs:

INFO: Analyzed target //:buildifier.check (66 packages loaded, 293 targets configured).
INFO: Found 1 target...
Target //:buildifier.check up-to-date:
  bazel-bin/buildifier.check.bash
INFO: Elapsed time: 0.406s, Critical Path: 0.00s
INFO: 5 processes: 5 internal.
INFO: Build completed successfully, 5 total actions
INFO: Running command line: bazel-bin/buildifier.check.bash
> 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant