Add handling for a Data value BEFORE the Key value. This will be discarded based on the selected Error Handling. Add Unit test for same. Increment deployment version.

Keith Martin · Keith Martin · commit 94a2f112da19 · 2013-05-20T03:51:14.000Z
git-tfs-id: [https://martin-source.visualstudio.com/DefaultCollection]$/IntegrationServices/Main;C113
diff --git a/TextFileSplitter/TextFileSplitter2012/TextFileSplitter.cs b/TextFileSplitter/TextFileSplitter2012/TextFileSplitter.cs
@@ -2302,16 +2302,24 @@ public override void PrimeOutput(int outputs, int[] outputIDs, PipelineBuffer[]
                                                     {
                                                         if (keyMasterValues.TryGetValue(keyColumnID, out currentValue))
                                                         {
-                                                            currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;
+                                                            //currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;
                                                         }
                                                     }
                                                     else
                                                     {
                                                         if (keyMasterValues.TryGetValue((int)ManageProperties.GetPropertyValue(currentOutputColumn.CustomPropertyCollection, ManageProperties.keyOutputColumnID), out currentValue))
                                                         {
-                                                            currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;
+                                                            //currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;
                                                         }
                                                     }
+                                                    if (currentValue != null)
+                                                    {
+                                                        currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;
+                                                    }
+                                                    else
+                                                    {
+                                                        throw new ArgumentNullException(currentOutputColumn.Name, String.Format("Key Value was NOT found for record number {0} of type {1}", recordsRead, RowTypeValue));
+                                                    }
                                                 }
                                                 else
                                                 {
@@ -2361,7 +2369,10 @@ public override void PrimeOutput(int outputs, int[] outputIDs, PipelineBuffer[]
                                                         {
                                                             errorBuffer.AddRow();
                                                             errorBuffer[2] = TruncateStringTo4000(String.Format("Exception {0} thrown on Record {1} for field {2}.", ex.Message, recordsRead, currentOutputColumn.Name));
-                                                            errorBuffer[3] = TruncateStringTo4000(currentOutputColumn.FileHelperField.GetValue(result).ToString());
+                                                            if (currentOutputColumn.FileHelperField != null)
+                                                            {
+                                                                errorBuffer[3] = TruncateStringTo4000(currentOutputColumn.FileHelperField.GetValue(result).ToString());
+                                                            }
                                                             errorBuffer[4] = TruncateStringTo4000(RowDataValue);
                                                             Object currentValue = null;
                                                             foreach (SSISOutputColumn errorOutputColumn in errorOutput.OutputColumnCollection)
diff --git a/TextFileSplitter/TextFileSplitterInstallx64/Product.wxs b/TextFileSplitter/TextFileSplitterInstallx64/Product.wxs
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
-  <?define ProductVersion = "1.0.12.0"?>
+  <?define ProductVersion = "1.0.13.0"?>
   <?define UpgradeCode = "A9EE6818-88C5-4E7F-A2E4-C7BC52E7FF8D"?>
   <?define Manufacturer = "Keith Martin"?>
   <?define PackageCode = "*"?>
diff --git a/TextFileSplitter/TextFileSplitterInstallx86/Product.wxs b/TextFileSplitter/TextFileSplitterInstallx86/Product.wxs
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
-  <?define ProductVersion = "1.0.12.0"?>
+  <?define ProductVersion = "1.0.13.0"?>
   <?define UpgradeCode = "944FC76C-F623-480F-A10D-A1994713BF87"?>
   <?define Manufacturer = "Keith Martin"?>
   <?define PackageCode = "*"?>
diff --git a/TextFileSplitter/UnitTestTextFileSplitter2012/BadDataFile.txt b/TextFileSplitter/UnitTestTextFileSplitter2012/BadDataFile.txt
@@ -1,4 +1,5 @@
-﻿001|12345|Start Invoice Record
+﻿099|2001-01-01|Joe Bloggs|Missing Key Value
+001|12345|Start Invoice Record
 002|2001-01-01|Joe Bloggs|Header Record
 003|15.00|1.00|Purchase of 15 $1 Items|Data Record
 003|16.00|1.00|Purchase of 16 $1 Items|Data Record
diff --git a/TextFileSplitter/UnitTestTextFileSplitter2012/TestPrimeOutput.cs b/TextFileSplitter/UnitTestTextFileSplitter2012/TestPrimeOutput.cs
@@ -64,7 +64,11 @@ public void SetupSQLCEDatabase()
             tableCreate = "CREATE TABLE [RowCountOutput] ([KeyValue] nvarchar(255), [NumberOfRows] integer, [KeyValueStatus] nvarchar(255))";
             command.CommandText = tableCreate;
             command.ExecuteNonQuery();
-            
+
+            tableCreate = "CREATE TABLE [Output099] ([KeyColumn1] uniqueidentifier, [output099Column1] nvarchar(50), [output099Column2] nvarchar(50), [output099Column3] nvarchar(50))";
+            command.CommandText = tableCreate;
+            command.ExecuteNonQuery();
+
 
             connection.Close();
             sqlCEEngine.Dispose();
@@ -620,11 +624,28 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
             instance.SetOutputProperty(keyID, ManageProperties.rowTypeValue, "001");
             IDTSOutputColumn100 keyColumn1 = instance.InsertOutputColumnAt(keyID, 1, "KeyColumn2", String.Empty);
             instance.SetOutputColumnDataTypeProperties(keyID, keyColumn1.ID, DataType.DT_I4, 0, 0, 0, 0);
+            //instance.SetOutputColumnProperty(keyID, keyColumn1.ID, ManageProperties.usageOfColumn, Utilities.usageOfColumnEnum.Key);
             IDTSOutputColumn100 keyColumn2 = instance.InsertOutputColumnAt(keyID, 2, "KeyColumn3", String.Empty);
             instance.SetOutputColumnDataTypeProperties(keyID, keyColumn2.ID, DataType.DT_WSTR, 20, 0, 0, 0);
             keyOutput.OutputColumnCollection[0].Name = "KeyColumn1";
             errorOutput.OutputColumnCollection[5].Name = "KeyColumn1";
 
+            // 002|2001-01-01|Joe Bloggs|Missing Key Value
+
+            IDTSOutput100 output002 = instance.InsertOutput(DTSInsertPlacement.IP_AFTER, keyID);//textFileSplitter.OutputCollection.New();
+            int outputID = output002.ID;
+            instance.SetOutputProperty(outputID, ManageProperties.rowTypeValue, "099");
+            instance.SetOutputProperty(outputID, ManageProperties.typeOfOutput, Utilities.typeOfOutputEnum.DataRecords);
+            output002.ErrorRowDisposition = DTSRowDisposition.RD_RedirectRow;
+            output002.TruncationRowDisposition = DTSRowDisposition.RD_RedirectRow;
+            IDTSOutputColumn100 output099Column1 = instance.InsertOutputColumnAt(outputID, 1, "output099Column1", String.Empty);
+            instance.SetOutputColumnDataTypeProperties(outputID, output099Column1.ID, DataType.DT_STR, 50, 0, 0, 1252);
+            IDTSOutputColumn100 output099Column2 = instance.InsertOutputColumnAt(outputID, 2, "output099Column2", String.Empty);
+            instance.SetOutputColumnDataTypeProperties(outputID, output099Column2.ID, DataType.DT_STR, 50, 0, 0, 1252);
+            IDTSOutputColumn100 output099Column3 = instance.InsertOutputColumnAt(outputID, 3, "output099Column3", String.Empty);
+            instance.SetOutputColumnDataTypeProperties(outputID, output099Column3.ID, DataType.DT_STR, 50, 0, 0, 1252);
+
+
             // Add SQL CE Connection
             ConnectionManager sqlCECM = null;
             IDTSComponentMetaData100 sqlCETarget = null;
@@ -638,6 +659,9 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
             CreateSQLCEComponent(package, dataFlowTask, "RowCountOutput", out sqlCECM, out sqlCETarget, out sqlCEInstance);
             CreatePath(dataFlowTask, numberOfRowsOutput, sqlCETarget, sqlCEInstance);
 
+            CreateSQLCEComponent(package, dataFlowTask, "Output099", out sqlCECM, out sqlCETarget, out sqlCEInstance);
+            CreatePath(dataFlowTask, output002, sqlCETarget, sqlCEInstance);
+
             PackageEventHandler packageEvents = new PackageEventHandler();
 
             Microsoft.SqlServer.Dts.Runtime.DTSExecResult result = package.Execute(null, null, packageEvents as IDTSEvents, null, null);
@@ -653,14 +677,14 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
                 connection.Open();
             }
 
-            SqlCeCommand sqlCommand = new SqlCeCommand("SELECT * FROM [ErrorResults] WHERE ErrorMessage = 'Unexpected Row Type Value 002 found on Record 2.'", connection);
+            SqlCeCommand sqlCommand = new SqlCeCommand("SELECT * FROM [ErrorResults] WHERE ErrorMessage = 'Unexpected Row Type Value 002 found on Record 3.'", connection);
             SqlCeDataReader sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
             int rowCount = 0;
             while (sqlData.Read())
             {
                 rowCount++;
             }
-            Assert.AreEqual(1, rowCount, "Record 2 Error Missing");
+            Assert.AreEqual(1, rowCount, "Record 3 Error Missing");
 
             sqlCommand.CommandText = "SELECT COUNT(*) FROM [ErrorResults] WHERE ErrorMessage LIKE 'Unexpected Row Type Value%'";
             sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
@@ -714,14 +738,14 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
             sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
             while (sqlData.Read())
             {
-                Assert.AreEqual(6, sqlData.GetInt32(0), "Number of RowCountOutput Rows incorrect");
+                Assert.AreEqual(7, sqlData.GetInt32(0), "Number of RowCountOutput Rows incorrect");
             }
 
             sqlCommand.CommandText = "SELECT * FROM [RowCountOutput] WHERE KeyValue = 'Total Records'";
             sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
             while (sqlData.Read())
             {
-                Assert.AreEqual(15, sqlData.GetInt32(1), "Number of Total Records incorrect");
+                Assert.AreEqual(16, sqlData.GetInt32(1), "Number of Total Records incorrect");
                 Assert.AreEqual("Disconnected", sqlData.GetString(2), "KeyValue Status on Total Records incorrect");
             }
 
@@ -737,7 +761,7 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
             sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
             while (sqlData.Read())
             {
-                Assert.AreEqual(14, sqlData.GetInt32(1), "Number of Error Records incorrect");
+                Assert.AreEqual(15, sqlData.GetInt32(1), "Number of Error Records incorrect");
                 Assert.AreEqual("Connected and Processed", sqlData.GetString(2), "KeyValue Status on Error Records incorrect");
             }
 
@@ -749,6 +773,13 @@ public void TestPrimeOutput_TestDataFileWithManyErrorsAndRowCountOutput()
                 Assert.AreEqual("Not configured", sqlData.GetString(2), "KeyValue Status on 003 incorrect");
             }
 
+            sqlCommand.CommandText = "SELECT COUNT(*) FROM [ErrorResults] WHERE ErrorMessage LIKE 'Exception Key Value%'";
+            sqlData = sqlCommand.ExecuteReader(CommandBehavior.Default);
+            while (sqlData.Read())
+            {
+                Assert.AreEqual(1, sqlData.GetInt32(0), "099 Value before Key Not Detected.");
+            }
+
 
             connection.Close();
         }

Original file line number	Diff line number	Diff line change
`@@ -2302,16 +2302,24 @@ public override void PrimeOutput(int outputs, int[] outputIDs, PipelineBuffer[]`
`2302`	`2302`	`{`
`2303`	`2303`	`if (keyMasterValues.TryGetValue(keyColumnID, out currentValue))`
`2304`	`2304`	`{`
`2305`		`- currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;`
	`2305`	`+ //currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;`
`2306`	`2306`	`}`
`2307`	`2307`	`}`
`2308`	`2308`	`else`
`2309`	`2309`	`{`
`2310`	`2310`	`if (keyMasterValues.TryGetValue((int)ManageProperties.GetPropertyValue(currentOutputColumn.CustomPropertyCollection, ManageProperties.keyOutputColumnID), out currentValue))`
`2311`	`2311`	`{`
`2312`		`- currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;`
	`2312`	`+ //currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;`
`2313`	`2313`	`}`
`2314`	`2314`	`}`
	`2315`	`+ if (currentValue != null)`
	`2316`	`+ {`
	`2317`	`+ currentBuffer[currentOutputColumn.OutputBufferID] = currentValue;`
	`2318`	`+ }`
	`2319`	`+ else`
	`2320`	`+ {`
	`2321`	`+ throw new ArgumentNullException(currentOutputColumn.Name, String.Format("Key Value was NOT found for record number {0} of type {1}", recordsRead, RowTypeValue));`
	`2322`	`+ }`
`2315`	`2323`	`}`
`2316`	`2324`	`else`
`2317`	`2325`	`{`
`@@ -2361,7 +2369,10 @@ public override void PrimeOutput(int outputs, int[] outputIDs, PipelineBuffer[]`
`2361`	`2369`	`{`
`2362`	`2370`	`errorBuffer.AddRow();`
`2363`	`2371`	`errorBuffer[2] = TruncateStringTo4000(String.Format("Exception {0} thrown on Record {1} for field {2}.", ex.Message, recordsRead, currentOutputColumn.Name));`
`2364`		`- errorBuffer[3] = TruncateStringTo4000(currentOutputColumn.FileHelperField.GetValue(result).ToString());`
	`2372`	`+ if (currentOutputColumn.FileHelperField != null)`
	`2373`	`+ {`
	`2374`	`+ errorBuffer[3] = TruncateStringTo4000(currentOutputColumn.FileHelperField.GetValue(result).ToString());`
	`2375`	`+ }`
`2365`	`2376`	`errorBuffer[4] = TruncateStringTo4000(RowDataValue);`
`2366`	`2377`	`Object currentValue = null;`
`2367`	`2378`	`foreach (SSISOutputColumn errorOutputColumn in errorOutput.OutputColumnCollection)`