XFCE: "Old key file format" dialog stays below unlock dialog

[ferenczy]

Overview

I know it's quite a corner case but I have a database that's using a key file apparently in some old format (generated by the original KeePass). So I get a warning dialog "Old key file format" when opening such database:

The problem is when I try to unlock the database initiated from the browser extension. After inserting the database password on the "Unlock Database" dialog and clicking the Unlock button, it looks like the whole KeePassXC gets hang - the dialog is grayed out with the spinner mouse cursor over it. I had to kill it several times. Then I have found out there's the "Old key file format" hidden beneath the "Unlock database" dialog.

Steps to Reproduce

1. Create a database with a key in the old key file format (don't ask me how)
2. Lock the database
3. Click the Reopen Database button on the browser extension
4. Enter the key file and click Unlock
5. The "Unlock Database" dialog should be grayed out with a spinner mouse cursor over it and the "Old key file format" dialog hidden beneath

Expected Behavior

The "Old key file format" dialog is opened on top of all other currently opened dialogs.

Or rather more generally: make sure that any dialog that's being opened is opened on top of all other currently open dialogs.

Actual Behavior

The "Old key file format" is hidden beneath the inactivated "Unlock Database" dialog.

Context

KeePassXC: 2.7.6
Revision: dd21def

Operating System: Ubuntu 22.04.3
Desktop Env: XFCE 4.16
Windowing System: X11

[droidmonkey]

We should only be showing this dialog on first unlock, imo. However this issue might have more to do with the xfce desktop env than anything else.

[ferenczy]

So isn't it reproducible under other WMs?

[droidmonkey]

Ahhh I see the problem, on Linux we set the "Always on Top" flag for the unlock dialog. This problem does not occur on Gnome or KDE though.

Since it doesn't happen anywhere else, and you can select the checkbox to not show it (or just update your key file), we won't be investing any time in correcting this issue at this point.