Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users select account from selection list under TOTP input field instead of browser extension button after 2FA expiration #1850

Open
ebbez opened this issue Feb 15, 2023 · 2 comments

Comments

@ebbez
Copy link

ebbez commented Feb 15, 2023

Currently, when a user has 2 accounts linked to a URL and has to re-authenticate their 2FA again after it expired, the user has to select their account from the browser extension button. This only happens when the user does not have to fill in their username/password, because usually the account gets filtered from the username/password form and then the TOTP is selected from the account used in the username/password form.

This takes more steps than it should (imo) and the extension also does not make it very clear why the TOTP button is not working in case no account gets selected in the extension button window (except for a small icon change), therefore I suggest moving the account selection for TOTP from the browser extension button to the input field where the TOTP has to be entered into.

Steps to Reproduce (for bugs)

  1. Have 2 accounts linked to microsoftonline.com / a website, one with a 2FA that expires after 30 mins.
  2. Log in using username/password, then TOTP will be automatically selected from the account with that combination.
  3. Wait till 2FA expires.
  4. Press TOTP button (nothing appears)
  5. Click on the KeePassXC browser extension button
  6. Select account

Possible solution

As said, it'd be more convenient and user-friendly if a selection list appeared on the TOTP button the same way a selection list appears when a user tries to fill in username/password and has 2 accounts.

Debug info

Browser: Firefox 109.0.1
Extension version: 1.8.4

@droidmonkey
Copy link
Member

We do show a selection list and an icon on the totp, the website you are accessing is likely messing that up for you. So we'll need to know the site to diagnose what's wrong.

Also, if you didn't go through a username password selection process, and you just are doing totp, how do we know which entry to choose?

@varjolintu
Copy link
Member

I guess the whole request is that there shouldn't be need to select an entry, but show TOTP for all entries in the Autocomplete Menu and Popup instead.

@varjolintu varjolintu added the 2fa label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants