Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a different error message when socket does not exist #1683

Open
NetSysFire opened this issue Jul 15, 2022 · 1 comment
Open

Provide a different error message when socket does not exist #1683

NetSysFire opened this issue Jul 15, 2022 · 1 comment

Comments

@NetSysFire
Copy link

Expected Behavior

You get an accurate error that the socket does not exist.

Current Behavior

You get a vague "key exchange failed" when /run/user/<uid>/org.keepassxc.KeePassXC.BrowserServer is not present due to e.g sandboxing via firejail which applies whitelisting.

Possible Solution

Better error message. I would have also edited the wiki to add that the socket location must be accessible but it is restricted. It has useful steps, but checking the socket location is missing.

This is not specific to my issue but ~/.mozilla/native-messaging-hosts should be accessible to the browser extension, so if org.keepassxc.keepassxc_browser.json does not exist you can provide a better error message here, too.

Steps to Reproduce (for bugs)

n/a

Debug info

KeePassXC - 2.7.1
KeePassXC-Browser - latest
Operating system: Linux
Browser: Firefox

@varjolintu
Copy link
Member

The only good solution for this is to pass the error message from the browser directly to the popup, as an addition to "Key exchange failed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants