Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap nodes connection logging #3376

Open
nkuba opened this issue Oct 25, 2022 · 0 comments
Open

Bootstrap nodes connection logging #3376

nkuba opened this issue Oct 25, 2022 · 0 comments

Comments

@nkuba
Copy link
Member

nkuba commented Oct 25, 2022

I'm afraid there may be something wrong with bootstrap rounds loggers, particularly the line logging all bootstrap attempts failed:

return fmt.Errorf("all bootstrap attempts failed")

I've noticed it a couple of times in the nodes that were connected to some of the bootstrap nodes. My understanding is that it should be logged only if a connection couldn't be established to any bootstrap node, but it may be logged differently.

We should revisit the bootstrap code and review all the loggers, so the logging messages are throwing errors only if it's really necessary (i.e. client failed to connect to any bootstrap node). Problems with connection to a particular bootstrap node should be logged as warnings.

We could also add a success message after establishing a connection to bootstrap nodes e.g. "established connection with 3 out of 5 bootstrap nodes".

@nkuba nkuba added this to the v2.0.0-m3 milestone Oct 25, 2022
@pdyraga pdyraga modified the milestones: v2.0.0-m3, v2.0.0-m4 Nov 21, 2022
@pdyraga pdyraga removed this from the v2.0.0-m4 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants