-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the v1 coverage pool #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document describes how v2 of coverage pools will work. For v1, we are going to provide another document describing the first release.
pdyraga
requested review from
dougvk,
Battenfield,
michalsmiarowski and
r-czajkowski
May 17, 2021 12:48
dougvk
previously approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The mechanism previously proposed has two flaws. First, it is hard to implement and requires a lot of additional bookkeeping in the contract given that multiple auctions can be open at the same time and all of them can generate a surplus. Secondly, it might happen that the auction gets opened for 0.0001 TBTC because the rest was filled by the surplus. In this scenario, the auction value is much lower than the minimum tBTC lot size and the auction length set by the governance could make not sense.
tomaszslabon
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes the v1, single-asset version of a coverage pool:
v2 of a coverage pool includes multi-asset coverage and rewards and is covered in v2 documentation.
Existing documentation for v2 has been moved to
docs-v2/design.adoc
and this is also where the work from #2 will eventually land.