Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the v1 coverage pool #52

Merged
merged 9 commits into from
May 21, 2021
Merged

Document the v1 coverage pool #52

merged 9 commits into from
May 21, 2021

Conversation

pdyraga
Copy link
Member

@pdyraga pdyraga commented May 17, 2021

This document describes the v1, single-asset version of a coverage pool:

  • components,
  • depositing and withdrawal from the pool,
  • tBTC v1 risk manager,
  • upgradability,
  • governance.

v2 of a coverage pool includes multi-asset coverage and rewards and is covered in v2 documentation.
Existing documentation for v2 has been moved to docs-v2/design.adoc and this is also where the work from #2 will eventually land.

@pdyraga pdyraga requested review from mhluongo and a team May 17, 2021 12:38
@pdyraga pdyraga changed the title Docs v2 Document the v1 coverage pool May 17, 2021
dougvk
dougvk previously approved these changes May 17, 2021
Copy link

@dougvk dougvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdyraga pdyraga requested a review from sashatanase May 19, 2021 09:23
docs/design.adoc Outdated Show resolved Hide resolved
docs/design.adoc Show resolved Hide resolved
The mechanism previously proposed has two flaws. First, it is hard to
implement and requires a lot of additional bookkeeping in the contract
given that multiple auctions can be open at the same time and all of
them can generate a surplus. Secondly, it might happen that the auction
gets opened for 0.0001 TBTC because the rest was filled by the surplus.
In this scenario, the auction value is much lower than the minimum tBTC
lot size and the auction length set by the governance could make not
sense.
@lukasz-zimnoch lukasz-zimnoch merged commit 00d2fdb into main May 21, 2021
@lukasz-zimnoch lukasz-zimnoch deleted the docs-v2 branch May 21, 2021 08:25
@pdyraga pdyraga added this to the solidity/v1.0.0 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants