Skip to content

Commit 3aee70f

Browse files
committed
Remove unneeded KIOMockNSURLSessionFactory class. Use an OCMock object instead.
1 parent 086d95d commit 3aee70f

File tree

4 files changed

+5
-61
lines changed

4 files changed

+5
-61
lines changed

KeenClient.xcodeproj/project.pbxproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@
101101
487715101EDF4FB400012B0B /* KeenLogSinkNSLog.m in Sources */ = {isa = PBXBuildFile; fileRef = 481A9B7B1E5690950094B985 /* KeenLogSinkNSLog.m */; };
102102
487715111EDF4FF100012B0B /* KeenLogger.m in Sources */ = {isa = PBXBuildFile; fileRef = 48583E061E58CDE2002CFD99 /* KeenLogger.m */; };
103103
487715121EDF535D00012B0B /* KIODefaultNSURLSessionFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = 487715091EDF474F00012B0B /* KIODefaultNSURLSessionFactory.m */; };
104-
487715151EDF53E600012B0B /* KIOMockNSURLSessionFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = 487715141EDF53E600012B0B /* KIOMockNSURLSessionFactory.m */; };
105104
488892441EC12D06008C6024 /* KeenEventTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 488892431EC12D06008C6024 /* KeenEventTests.m */; };
106105
4888924A1EC12E81008C6024 /* KeenGeoLocationTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 488892491EC12E81008C6024 /* KeenGeoLocationTests.m */; };
107106
4888924D1EC13C21008C6024 /* TestDatabaseRequirement.m in Sources */ = {isa = PBXBuildFile; fileRef = 4888924C1EC13C21008C6024 /* TestDatabaseRequirement.m */; };
@@ -230,8 +229,6 @@
230229
487715091EDF474F00012B0B /* KIODefaultNSURLSessionFactory.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = KIODefaultNSURLSessionFactory.m; sourceTree = "<group>"; };
231230
4877150A1EDF474F00012B0B /* KIODefaultNSURLSessionFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KIODefaultNSURLSessionFactory.h; sourceTree = "<group>"; };
232231
4877150B1EDF474F00012B0B /* KIONSURLSessionFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KIONSURLSessionFactory.h; sourceTree = "<group>"; };
233-
487715131EDF53E600012B0B /* KIOMockNSURLSessionFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KIOMockNSURLSessionFactory.h; sourceTree = "<group>"; };
234-
487715141EDF53E600012B0B /* KIOMockNSURLSessionFactory.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = KIOMockNSURLSessionFactory.m; sourceTree = "<group>"; };
235232
488892421EC12D06008C6024 /* KeenEventTests.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KeenEventTests.h; sourceTree = "<group>"; };
236233
488892431EC12D06008C6024 /* KeenEventTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = KeenEventTests.m; sourceTree = "<group>"; };
237234
488892481EC12E81008C6024 /* KeenGeoLocationTests.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = KeenGeoLocationTests.h; sourceTree = "<group>"; };
@@ -503,8 +500,6 @@
503500
481496EB1EC3832C00A9DEED /* SavedQueryTests.m */,
504501
48CAA1761ED60792003C2008 /* DatasetTests.h */,
505502
48CAA1771ED60792003C2008 /* DatasetTests.m */,
506-
487715131EDF53E600012B0B /* KIOMockNSURLSessionFactory.h */,
507-
487715141EDF53E600012B0B /* KIOMockNSURLSessionFactory.m */,
508503
);
509504
name = Tests;
510505
sourceTree = "<group>";
@@ -788,7 +783,6 @@
788783
isa = PBXSourcesBuildPhase;
789784
buildActionMask = 2147483647;
790785
files = (
791-
487715151EDF53E600012B0B /* KIOMockNSURLSessionFactory.m in Sources */,
792786
CA6410E218E39F3A00E53E3C /* KIODBStoreTests.m in Sources */,
793787
486B596E1EB29B0A00D5251D /* KeenTestCaseBase.m in Sources */,
794788
48CAA1781ED60792003C2008 /* DatasetTests.m in Sources */,

KeenClientTests/KIOMockNSURLSessionFactory.h

Lines changed: 0 additions & 17 deletions
This file was deleted.

KeenClientTests/KIOMockNSURLSessionFactory.m

Lines changed: 0 additions & 34 deletions
This file was deleted.

KeenClientTests/KeenTestCaseBase.m

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#import "HTTPCodes.h"
2121
#import "TestDatabaseRequirement.h"
2222
#import "KIODBStoreTestable.h"
23-
#import "KIOMockNSURLSessionFactory.h"
2423

2524
#import "KeenTestCaseBase.h"
2625

@@ -169,13 +168,15 @@ - (id)createClientWithResponseData:(id)data
169168
id mockSession =
170169
[self mockUrlSessionWithResponse:response andResponseData:serializedData andRequestValidator:requestValidator];
171170

172-
id<KIONSURLSessionFactory> sessionFactory = [[KIOMockNSURLSessionFactory alloc] initWithSession:mockSession];
173-
171+
id mockSessionFactory = OCMProtocolMock(@protocol(KIONSURLSessionFactory));
172+
OCMStub([mockSessionFactory session]).andReturn(mockSession);
173+
OCMStub([mockSessionFactory sessionWithConfiguration:[OCMArg any]]).andReturn(mockSession);
174+
174175
// Create/get store
175176
KIODBStore *store = KIODBStore.sharedInstance;
176177

177178
// Create network
178-
KIONetwork *network = [[KIONetwork alloc] initWithURLSessionFactory:sessionFactory andStore:store];
179+
KIONetwork *network = [[KIONetwork alloc] initWithURLSessionFactory:mockSessionFactory andStore:store];
179180

180181
// Create uploader
181182
KIOUploader *uploader = [[KIOUploader alloc] initWithNetwork:network andStore:store];

0 commit comments

Comments
 (0)