Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oss to cloud protocols #4082

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

rongfengliang
Copy link
Contributor

CLOUD_PROTOCOLS add more official fsspec implament (oss, swift,dropbox)

Description

CLOUD_PROTOCOLS add more official fsspec implament (oss, swift,dropbox)

Development notes

I have test with oss , others maybe also OK

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • [x ] Read the contributing guidelines
  • [x ] Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

CLOUD_PROTOCOLS add  more official fsspec implament (oss, swift,dropbox) 

Signed-off-by: rong fengliang <1141591465@qq.com>
@merelcht merelcht changed the title Update core.py Add support for oss, swift, and dropbox to cloud protocols Sep 5, 2024
@merelcht
Copy link
Member

merelcht commented Sep 5, 2024

Hi @rongfengliang, thanks for opening this PR! 🙂

I see in the description you say:

I have test with oss , others maybe also OK

Would it be possible for you to try the other protocols as well? I'd feel more comfortable adding it to the codebase knowing it works.

Thanks!

Signed-off-by: rong fengliang <1141591465@qq.com>
@rongfengliang rongfengliang changed the title Add support for oss, swift, and dropbox to cloud protocols Add support for oss to cloud protocols Sep 5, 2024
@rongfengliang
Copy link
Contributor Author

rongfengliang commented Sep 5, 2024

Hi @rongfengliang, thanks for opening this PR! 🙂

I see in the description you say:

I have test with oss , others maybe also OK

Would it be possible for you to try the other protocols as well? I'd feel more comfortable adding it to the codebase knowing it works.

Thanks!

@merelcht
I I do not have the relevant resources or accounts, so I remove dropbox and swift support

merelcht and others added 4 commits September 5, 2024 13:57
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test this myself but I checked that fsspec does have an oss protocol so I expect it works the same?

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rongfengliang

@merelcht merelcht enabled auto-merge (squash) September 20, 2024 11:18
@merelcht merelcht merged commit fd6a69d into kedro-org:main Sep 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants