Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old code/mentions related to jupyter convert #3963

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Remove old code/mentions related to jupyter convert #3963

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e7da7
Remove old code/mentions related to jupyter convert
merelcht Jun 19, 2024
0660c4f
Remove unneeded custom JupyterCommandGroup
merelcht Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions features/steps/cli_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,18 +711,6 @@ def check_dependency_in_reqs(context: behave.runner.Context, dependency: str):
assert dependency in reqs_path.read_text()


@then("Code cell with node tag should be converted into kedro node")
def check_cell_conversion(context: behave.runner.Context):
converted_file = (
context.root_project_dir
/ "src"
/ context.package_name
/ "nodes"
/ "hello_world.py"
)
assert "Hello World!" in converted_file.read_text()


@given("I have micro-packaging settings in pyproject.toml")
def add_micropkg_to_pyproject_toml(context: behave.runner.Context):
pyproject_toml_path = context.root_project_dir / "pyproject.toml"
Expand Down
12 changes: 2 additions & 10 deletions kedro/framework/cli/jupyter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,13 @@
from kedro.framework.project import validate_settings
from kedro.framework.startup import ProjectMetadata

CONVERT_ALL_HELP = """Extract the nodes from all notebooks in the Kedro project directory,
including sub-folders."""

OVERWRITE_HELP = """If Python file already exists for the equivalent notebook,
overwrite its contents."""


class JupyterCommandGroup(click.Group):
"""A custom class for ordering the `kedro jupyter` command groups"""

def list_commands(self, ctx: click.Context) -> list[str]:
"""List commands according to a custom order"""
return ["setup", "notebook", "lab", "convert"]
return ["setup", "notebook", "lab"]
merelcht marked this conversation as resolved.
Show resolved Hide resolved


@click.group(name="Kedro")
Expand All @@ -43,9 +37,7 @@ def jupyter_cli() -> None: # pragma: no cover

@jupyter_cli.group(cls=JupyterCommandGroup)
def jupyter() -> None:
"""Open Jupyter Notebook / Lab with project specific variables loaded, or
convert notebooks into Kedro code.
"""
"""Open Jupyter Notebook / Lab with project specific variables loaded."""


@forward_command(jupyter, "setup", forward_help=True)
Expand Down