-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the release process to GitHub Actions #3491
Move the release process to GitHub Actions #3491
Conversation
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB ⭐ ! I left some comments about the Github release step but overall looks good to me!
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⭐ Great to see so many cci
files go already. Not long until we can remove everything!
Description
Context: #2969
An example working flow can be seen on my personal repository: https://github.com/SajidAlamQB/kedro1
Test PyPi: https://test.pypi.org/project/kedro-test-pypi/0.19.1/
Similar to kedro plugins we need to add repository secrets for github:
GH_TAGGING_TOKEN
and pypi:KEDRO_PYPI_TOKEN
Development notes
Took most of the workflow example from https://github.com/kedro-org/kedro-plugins/blob/main/.github/workflows/check-release.yml and adapted it for kedro.
Removed all CircleCI related release scripts.
Included the automatic GitHub tag and release creation with release notes.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file