Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the release process to GitHub Actions #3491

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Jan 8, 2024

Description

Context: #2969

An example working flow can be seen on my personal repository: https://github.com/SajidAlamQB/kedro1
Test PyPi: https://test.pypi.org/project/kedro-test-pypi/0.19.1/

Similar to kedro plugins we need to add repository secrets for github: GH_TAGGING_TOKEN and pypi: KEDRO_PYPI_TOKEN

Development notes

Took most of the workflow example from https://github.com/kedro-org/kedro-plugins/blob/main/.github/workflows/check-release.yml and adapted it for kedro.

Removed all CircleCI related release scripts.

Included the automatic GitHub tag and release creation with release notes.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@SajidAlamQB SajidAlamQB self-assigned this Jan 8, 2024
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@SajidAlamQB SajidAlamQB linked an issue Jan 8, 2024 that may be closed by this pull request
SajidAlamQB and others added 3 commits January 8, 2024 16:00
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@SajidAlamQB SajidAlamQB marked this pull request as ready for review January 9, 2024 23:55
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SajidAlamQB ⭐ ! I left some comments about the Github release step but overall looks good to me!

.github/workflows/check-release.yml Outdated Show resolved Hide resolved
.github/workflows/check-release.yml Outdated Show resolved Hide resolved
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
@merelcht
Copy link
Member

GH_TAGGING_TOKEN is my personal token, so that should just work fine without changes. I've created KEDRO_PYPI_TOKEN.

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐ Great to see so many cci files go already. Not long until we can remove everything!

@SajidAlamQB SajidAlamQB merged commit b499da0 into main Jan 11, 2024
30 checks passed
@SajidAlamQB SajidAlamQB deleted the dev/move-release-workflow-to-github-actions branch January 11, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the release process to GitHub Actions
3 participants