Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication and inconsistencies exist across different documentation subprojects #3586

Closed
astrojuanlu opened this issue Feb 1, 2024 · 10 comments
Assignees
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@astrojuanlu
Copy link
Member

astrojuanlu commented Feb 1, 2024

Description

We are starting to have lots of duplicated work across our 3 subprojects: core, viz, and datasets. This includes

Context

This situation is starting to pose some problems. For example, now making small adjustments to the CSS requires access to an object storage and they are not under version control. In addition, we now have inconsistent documentation dependencies across repositories, and maintaining them in sync is a burden.

We'd need to tackle this before #4257.

Possible Implementation

Create a custom Sphinx theme, so we can do

# pyproject.toml
[project.optional-dependencies]
docs = [
    "kedro-sphinx-theme==0.1.0",
]

And that already contains everything we need.

Possible Alternatives

@astrojuanlu astrojuanlu added Component: Documentation 📄 Issue/PR for markdown and API documentation Component: DevOps Issue/PR that addresses automation, CI, GitHub setup labels Feb 1, 2024
@stichbury
Copy link
Contributor

Agreed. However, does it make sense to wait and make the theme based on docs redesign or can we make a theme now for what we have and then upgrade it? And, also, who makes this theme -- is it front end work for the Viz developers?

@astrojuanlu
Copy link
Member Author

For clarity, we wouldn't be crafting anything new: just packing our existing sphinx-rtd-theme modifications into a pip-installable package. So in principle this is "backend" work only.

Then that pip-installable package gives us the foundation to make any actual modifications to the theme itself.

@astrojuanlu
Copy link
Member Author

More inconsistencies across projects: kedro-org/kedro-viz#1734

@tynandebold
Copy link
Member

CSS files (now in an external storage for reuse, see #3016)

I opened a PR in the brand identity repo to solve this first point: kedro-org/kedro-brand-identity#7

@astrojuanlu
Copy link
Member Author

Okay, it's happening https://github.com/kedro-org/kedro-sphinx-theme

@astrojuanlu
Copy link
Member Author

Adding this to our backlog so we can prioritize accordingly.

@astrojuanlu astrojuanlu removed their assignment Apr 3, 2024
@astrojuanlu
Copy link
Member Author

Waiting for reviews on #3675

@astrojuanlu
Copy link
Member Author

astrojuanlu commented May 3, 2024

@astrojuanlu
Copy link
Member Author

This has now been addressed across all 3 subprojects. Closing.

@astrojuanlu
Copy link
Member Author

Follow-up #3864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
Archived in project
Development

No branches or pull requests

3 participants