Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency on add_ons metadata in pyproject.toml when none #3336

Closed
SajidAlamQB opened this issue Nov 23, 2023 · 1 comment
Closed

Inconsistency on add_ons metadata in pyproject.toml when none #3336

SajidAlamQB opened this issue Nov 23, 2023 · 1 comment

Comments

@SajidAlamQB
Copy link
Contributor

SajidAlamQB commented Nov 23, 2023

Description

There is an inconsistency on what value add_ons in pyproject.toml is assigned.

Case 1:

kedro new --addons=none

pyproject.toml:

[tool.kedro]
add_ons = ""

Case 2:
kedro new (Use default value for add-ons, none, by pressing enter without typing any add-ons)

pyproject.toml:

[tool.kedro]
add_ons = "[]"

We should keep consistency in how to label none.

@SajidAlamQB SajidAlamQB changed the title Inconsistency on what value add_ons when none Inconsistency on add_ons value in pyproject.toml when none Nov 23, 2023
@SajidAlamQB SajidAlamQB changed the title Inconsistency on add_ons value in pyproject.toml when none Inconsistency on add_ons metadata in pyproject.toml when none Nov 23, 2023
@merelcht merelcht moved this to To Do in Kedro Framework Jan 22, 2024
@AhdraMeraliQB
Copy link
Contributor

Closing as no longer applicable, all none selections will result in a value of ["None"] in the project's pyproject.toml. xref the file refactor, the developer docs.

@github-project-automation github-project-automation bot moved this from To Do to Done in Kedro Framework Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants