-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in kedro new
with --config
#3335
Comments
Problems 3 and 4 are still actual, but I'm uncertain about solution.
I think it should be good to discuss solution first, do you have any thoughts on that: @ankatiyar , @SajidAlamQB , @lrcouto , @AhdraMeraliQB , @noklam , @merelcht |
I agree, that these are both breaking, I think the idea was these were nice-to-haves to be done before 0.19.0 that didn't make the cut. For 3, I don't see much of an issue here, I assume Regarding 4, I would agree that it would be nice to have a single standard way of providing this information, but I do think this would require input from design (and given it's a breaking change, we might get user feedback on what they'd like, or if they mind, before the time for implementing this comes around). A way to get around the breaking change would be to agree on what we would like it changed to, implement it, but keep the current system as well (with a deprecation warning at some point), removing the old syntax at 0.20.0/1.0.0. It would probably be around for quite some time though. In summary, I think we can leave point 3. For point 4 I'm not opposed to creating a separate issue for the design -> implementation -> deprecation -> eventual-removal process, but at a Low priority |
Technically these changes are indeed breaking, but the |
+1, I think issue 3 is not that big a deal as long as the documentation makes it clear to use |
Description
Creating a new project with the
--config
flag doesn't work properly. There's multiple inconsistencies in the flow.Problem 1:
#3342
Problem 2:
#3343
Problem 3:
--example
and the fields you have to use inconfig.yml
and prompts instead, i.e.example_pipeline
.According to the discussion below, we decided to leave it as is
Problem 4:
tools
inconfig.yml
and prompts takes numeric values1,2,3
but--tools
takeslint,test,docs
According to the discussion below, we decided to use short text in
config.yml
instead of numbers to be consistent with--tools
The text was updated successfully, but these errors were encountered: