Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons: Minor issues/improvements #3333

Closed
ankatiyar opened this issue Nov 23, 2023 · 2 comments · Fixed by #3426
Closed

Add-ons: Minor issues/improvements #3333

ankatiyar opened this issue Nov 23, 2023 · 2 comments · Fixed by #3426

Comments

@ankatiyar
Copy link
Contributor

ankatiyar commented Nov 23, 2023

Description

Collecting stuff I found during bug bash related to the add-ons/tools workflow here -

Add ons info in pyproject.toml

This currently gets added to the project's pyproject.toml as a string -

add_ons = "['Linting', 'Custom Logging', 'Documentation']"

Could this be a list for easier analytics on Heap side -

add_ons = ['Linting', 'Custom Logging', 'Documentation']

Additionally, could the selection of "example pipeline" be included in this?

@merelcht
Copy link
Member

Quickly discussed this and it would be nicer to have "example" as a separate entry.

@ankatiyar
Copy link
Contributor Author

Also found this while testing -
kedro new --addons=lint,test,lint,test
or entering repeat numbers in the prompt does not fail but ends up adding this to the pyproject.toml:

add_ons = "['Linting', 'Testing', 'Linting', 'Testing']"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants