-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and revise PyPI page for Kedro #2952
Comments
The contents of the page are derived from Line 73 in c9fc80a
|
Interesting, so if we modify a README (like I did recently) and we don't do an immediate release, they get out of step as they've done here. I wonder with the graphic though because that hasn't changed. Looking at the source on PyPI it seems to have taken the graphic link we provide in readme and built a new link, which is returning an invalid type error. I wonder if we should stick to text given the
|
I'm not 100 % sure but for the case of images, we'll probably have to change Line 40 in 4563a4c
with the corresponding "raw" URLs, in this case https://raw.githubusercontent.com/kedro-org/kedro-viz/main/.github/img/banner.png |
Labeling this as a bug, we shouldn't have a broken PyPI page |
I vote to remove the pipeline visualisation since that's a Viz feature and we link to viz anyway; the graphic is on that README where it should be. We need to fix that in the https://pypi.org/project/kedro-viz/ page so let's do as you suggest and use the raw URL to see if works. I'm start on a PR for all this. |
Fixed in two merged PRs |
Description
https://pypi.org/project/kedro/ is looking a bit dated now we've updated our contribution guide and set up
awesome-kedro
. There's also a missing graphic and the badges don't work :-0As a matter of priority, let's review the page and revise it to fix any issues with it.
The text was updated successfully, but these errors were encountered: