Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make starter tests use non-deprecated dataset #2933

Closed
astrojuanlu opened this issue Aug 16, 2023 · 1 comment
Closed

Make starter tests use non-deprecated dataset #2933

astrojuanlu opened this issue Aug 16, 2023 · 1 comment
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup

Comments

@astrojuanlu
Copy link
Member

Description

kedro/features/steps/test_starter/{{ cookiecutter.repo_name }}/src/requirements.txt

Line 9 in 16dd1df

kedro[pandas.CSVDataSet]=={{ cookiecutter.kedro_version }}

This should be kedro-datasets[pandas.CSVDataSet] instead (even though we might soon deprecate that name, see kedro-org/kedro-plugins#306)

Context

Possible Implementation

Possible Alternatives
@astrojuanlu astrojuanlu added Issue: Feature Request New feature or improvement to existing feature Component: DevOps Issue/PR that addresses automation, CI, GitHub setup and removed Issue: Feature Request New feature or improvement to existing feature labels Aug 16, 2023
@astrojuanlu astrojuanlu mentioned this issue Aug 16, 2023
Merged
5 tasks
@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@merelcht
Copy link
Member

This issue is outdated and has already been done, see: https://github.com/kedro-org/kedro/blob/main/features/steps/test_starter/%7B%7B%20cookiecutter.repo_name%20%7D%7D/requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrojuanlu @merelcht