Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractConfigLoader have a signature of conf_source: str, but it should be conf_source : str | Path #2886

Open
noklam opened this issue Aug 2, 2023 · 0 comments
Open

AbstractConfigLoader have a signature of conf_source: str, but it should be conf_source : str | Path #2886

noklam opened this issue Aug 2, 2023 · 0 comments

Comments

@noklam
Copy link
Contributor

noklam commented Aug 2, 2023 •
edited
Loading

Description

  • update the signature to accept Path
  • update all tests to remove the unnecessary conversion from path to str.

Sorry, I mean if tmp_path alone works? I check the definition of AbstractConfigLoader have a signature of conf_source: str, but I expect it should be conf_source : str | Path.
image

A quick experiment suggests that it should work

image

cc @merelcht

Originally posted by @noklam in #2869 (comment)
@noklam noklam changed the title Sorry, I mean if tmp_path alone works? I check the definition of AbstractConfigLoader have a signature of conf_source: str, but I expect it should be conf_source : str | Path. AbstractConfigLoader have a signature of conf_source: str, but it should be conf_source : str | Path Aug 2, 2023
@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noklam