Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for defining layer attribute at top-level within catalog #2678

Closed
AhdraMeraliQB opened this issue Jun 13, 2023 · 1 comment · Fixed by #3402
Closed

Remove support for defining layer attribute at top-level within catalog #2678

AhdraMeraliQB opened this issue Jun 13, 2023 · 1 comment · Fixed by #3402
Assignees
@lrcouto

Comments

@AhdraMeraliQB
Copy link
Contributor

Note. Breaking, goes in 0.19.0.

After the implementation of #2440, it was decided that layer would move to within the introduced metadata result. As a result we will drop support for defining it at the top-level. Layer, at the top-level, is currently handled in https://github.com/kedro-org/kedro/blob/main/kedro/io/data_catalog.py#L183.
@merelcht merelcht moved this to To Do in Kedro Framework Oct 25, 2023
@lrcouto lrcouto moved this from To Do to In Progress in Kedro Framework Dec 4, 2023
@lrcouto lrcouto linked a pull request Dec 7, 2023 that will close this issue
Remove logic to define layer at the top level from DataCatalog #3402
Merged
7 tasks
@lrcouto lrcouto moved this from In Progress to In Review in Kedro Framework Dec 7, 2023
@merelcht
Copy link
Member

Completed in #3402

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Dec 11, 2023
@merelcht merelcht removed this from the Redesign the API for IO (catalog) milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrcouto lrcouto

Labels
None yet
Projects
Kedro Framework
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove logic to define layer at the top level from DataCatalog kedro-org/kedro
3 participants
@merelcht @lrcouto @AhdraMeraliQB