-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review deployment pages and consider how to integrate GetInData plugins docs and improve them overall #2435
Comments
@stichbury How can we proceed on that? |
@marrrcin We are still looking at changes to the information architecture, so this is difficult to pin down at present. In the current table of contents, what would you propose? A section in the Kedro plugins page? Or a new section about plugins with tutorials listed? You probably have some great ideas on how to position these in the current layout, which was can take forward as we think about the new one as part of #1866 |
There is a section called "Deployment" already, it's a good fit for our plugins. Actually some of the parts that are currently included there (e.g. SageMaker) can be replaced with the plugin-based approach. |
cc @deepyaman should we raise the priority of this one? |
This is in the current sprint w/c 17-04 |
I've done a little bit of reorganisation on the table of contents in the docs recently, which is unreleased at present, but should go out soon (you can see it in the
Turning to the deployment targets, I have these so far:
|
OK, I've got a little table going up in the previous comment, to track our confidence and the completeness of various deployment pages. Please could I ask for some technical help from the usual suspects: @deepyaman @noklam @merelcht @marrrcin @astrojuanlu to answer the 3 questions above and noted in the table:
Feel free to either drop a comment below for anything you want to comment on, or edit the table directly above if you're brave enough/foolish enough to want to wrangle a markdown table. From your input, I'll build a set of tickets to plan out updates to the deployment content (if not the location in the docs). Also, another question. Are there any missing targets? We don't have Databricks in this section, for example, but should provide a link to the docs stored elsewhere (and reconsider the distribution of Databricks docs in due course). |
My thoughts on the deployment targets listed above (fyi I haven't recently tried any of this so I'm totally guessing if these recommendations still work):
|
Thanks @merelcht that is amazingly useful. Given that you're unsure about Airflow, Argo and Batch, I'll ask @deepyaman for a second opinion on those, but TBH, I'm happy to just slate those for an update when there's opportunity (and look at usage logs to see which to prioritise) |
My two cents:
|
I agree with Merel mostly, I have some minor comments.
|
Thanks @marrrcin, that's very useful. I'll take your input on Airflow on board, and likewise for Azure. I plan to add some text for that as you suggest. And to @noklam also, thank you 🙏 I have no idea how I missed AWS Steps. I'll add it to my list, and add it to the flowchart. Also, we don't have any copy about "Which AWS to use?" but that would be very useful. Let me get that on my list too. |
I've revamped the quickstart guide for AzureML here: https://kedro-azureml.readthedocs.io/en/0.4.1/source/03_quickstart.html |
I'm a bit late to the party, but regarding Prefect, notice that they're written for 1.x, and Prefect 2.0 changed a few things #2431 so I'd give those an amber rating too 🟠 |
I will create a pair of tickets for updating the Prefect docs and Airflow/Astronomer docs to the latest versions. |
Following discussion with the GetInData team, we should look to include more official documentation about Kedro plugins for deployment within our official guides.
One option is to add some docs on our side and point through to the docs e.g. https://kedro-azureml.readthedocs.io/en/0.3.6/ for Azure ML (which should probably be the first one, as it’s the most battle tested and feature complete one).
An alternative is that those plugin docs are brought inside our docs entirely (which has the benefit that the user stays on one location and has one style of docs to read) but also adds to the content load, which is already heavy.
I didn't have a ticket about this so have created one for discussion. Tagging in https://github.com/marrrcin
The text was updated successfully, but these errors were encountered: